1400957 - WebExtensions proxy API - Unrecognized proxy type: "socks5"

Status: RESOLVED DUPLICATE of bug 1378205

(WebExtensions :: General, defect)

Description

[athoscribeiro]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170901071738

Steps to reproduce:

When developing an addon to use the proxy WebExtensions API, I followed the documentation, at https://developer.mozilla.org/en-US/docs/Web/HTTP/Proxy_servers_and_tunneling/Proxy_Auto-Configuration_(PAC)_file#Return_value_format to set a SOCKS5 proxy, using the "SOCKS5" string in the PAC file.


Actual results:

As reported in https://github.com/athos-ribeiro/noturno/issues/11, we got the following error:

Proxy error: FindProxyForURL: Unrecognized proxy type: "socks5"


Expected results:

It should recognize the SOCKS5 string, as pointed in the API documentation.

Aditional information:

I did change the sting to SOCKS to make my addon feature functional, but I believe either the documentation or the implementation should change here. I also checked https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/extensions/ProxyScriptContext.jsm#l46 to make sure the documentation was not referring to some unreleased feature.