Closed
Bug 1400975
Opened 7 years ago
Closed 7 years ago
Add specific placeholders for the sidebar search boxes
Categories
(Firefox :: Menus, enhancement, P4)
Firefox
Menus
Tracking
()
RESOLVED
FIXED
Firefox 57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: rfeeley, Assigned: jaws)
Details
Attachments
(2 files)
sidebar-placeholders.png
It has been observed that users expect sidebar search boxes to search the Internet, and not sidebar content.
Let's make the placeholder specific to the content being search (like we do with "Find in page")
See attached.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: -- → P4
Version: 55 Branch → Trunk
| Comment hidden (mozreview-request) |
|
Reporter | |
Comment 2•7 years ago
|
||
Oops… Michelle, should placeholders be title cased?
Flags: needinfo?(mheubusch)
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8909985 [details]
Bug 1400975 - Add specific placeholders for the sidebar search boxes.
https://reviewboard.mozilla.org/r/181476/#review186784
Code looks good to me, r+ with whichever casing is correct.
Attachment #8909985 -
Flags: review?(adw) → review+
Ryan, the casing as you have it (sentence case) is correct. No changes needed.
Flags: needinfo?(mheubusch)
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c93bc259282
Add specific placeholders for the sidebar search boxes. r=adw
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in
before you can comment on or make changes to this bug.
Description
•