Closed
Bug 1400992
Opened 7 years ago
Closed 7 years ago
Intermittent test_safe_browsing_warning_pages.py TestSafeBrowsingWarningPages.test_warning_pages | NoSuchElementException: Unable to locate element: getMeOutButton
Categories
(Testing :: Firefox UI Tests, defect, P5)
Tracking
(firefox-esr52 unaffected, firefox55 unaffected, firefox56 unaffected, firefox57 fixed)
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox55 | --- | unaffected |
| firefox56 | --- | unaffected |
| firefox57 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: prathiksha)
References
Details
(Keywords: intermittent-failure, regression, Whiteboard: [stockwell fixed:other])
Attachments
(1 file)
Filed by: hskupin [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=131805892&repo=autoland https://queue.taskcluster.net/v1/task/N-saNRQAQJOpdYgL7D_mdg/runs/0/artifacts/public/logs/live_backing.log
|
||
Comment 1•7 years ago
|
||
Regression from bug 1363051. Francois or prathiksha, can you please take care of this regression? Thanks.
status-firefox56:
--- → unaffected
status-firefox57:
--- → affected
Flags: needinfo?(prathikshaprasadsuman)
Flags: needinfo?(francois)
Keywords: regression
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → prathikshaprasadsuman
Flags: needinfo?(prathikshaprasadsuman)
|
||
Updated•7 years ago
|
Flags: needinfo?(francois)
| Comment hidden (Intermittent Failures Robot) |
|
|
||
Comment 3•7 years ago
|
||
Can we please get this permanent failure fixed ASAP? It's very annoying and its very likely that the useful test will be disabled soon.
|
|
Assignee | |
Comment 4•7 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #3) > Can we please get this permanent failure fixed ASAP? It's very annoying and > its very likely that the useful test will be disabled soon. Of course. I just got back to my computer. I'll fix it soon. :)
| Comment hidden (mozreview-request) |
|
||
Updated•7 years ago
|
Whiteboard: [stockwell needswork]
|
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8909785 [details] Bug 1400992 - Fix test_safe_browsing_warning_pages.py. https://reviewboard.mozilla.org/r/181272/#review186524 ::: testing/firefox-ui/tests/functional/security/test_safe_browsing_warning_pages.py:89 (Diff revision 1) > + "phishing-malware"; > """) > > - button = self.marionette.find_element(By.ID, "reportButton") > + button = self.marionette.find_element(By.ID, 'seeDetailsButton') > button.click() > + time.sleep(1) Why do you need sleep here? Please never use it in a test. Instead Wait().until() should be used if the expected element is not present right away. ::: testing/firefox-ui/tests/functional/security/test_safe_browsing_warning_pages.py:112 (Diff revision 1) > self.assertEquals(topic.text, "phishing-malware") > > def check_ignore_warning_button(self, unsafe_page): > - button = self.marionette.find_element(By.ID, 'ignoreWarningButton') > + button = self.marionette.find_element(By.ID, 'seeDetailsButton') > button.click() > + time.sleep(1) Same here. Can you please trigger try builds so that I can see what's going on here? Thanks.
Attachment #8909785 -
Flags: review?(hskupin) → review-
|
|
||
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8909785 [details] Bug 1400992 - Fix test_safe_browsing_warning_pages.py. https://reviewboard.mozilla.org/r/181272/#review186526 I would also like to see a review from Francois regarding the behavior changes.
|
|
||
Updated•7 years ago
|
Attachment #8909785 -
Flags: review?(francois)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8909785 -
Flags: review?(hskupin) → review?(francois)
|
|
||
Comment 9•7 years ago
|
||
Comment on attachment 8909785 [details] Bug 1400992 - Fix test_safe_browsing_warning_pages.py. https://reviewboard.mozilla.org/r/181272/#review186538 r=me with passing jobs on try.
Attachment #8909785 -
Flags: review+
|
|
||
Comment 10•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8909785 [details] Bug 1400992 - Fix test_safe_browsing_warning_pages.py. https://reviewboard.mozilla.org/r/181272/#review186602
Attachment #8909785 -
Flags: review?(francois) → review+
|
|
||
Comment 11•7 years ago
|
||
To get this bug fixed I went ahead and triggered the landing of the patch.
|
||
Comment 12•7 years ago
|
||
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6e57f448953d Fix test_safe_browsing_warning_pages.py. r=francois,whimboo
| Comment hidden (Intermittent Failures Robot) |
|
|
||
Comment 14•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6e57f448953d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
| Comment hidden (Intermittent Failures Robot) |
|
|
||
Comment 16•7 years ago
|
||
Ryan, due to the early merge of m-c to m-b it looks like this would be needed there to prevent the massive failures. Should we do an uplift or wait until the next merge?
Flags: needinfo?(ryanvm)
|
|
||
Comment 17•7 years ago
|
||
Oh wait. This was already done with the following push, which made the test passing on beta. Thanks everyone! https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=4bfb0b8fb6b1da31cb6c22b243bb071b6db01984&filter-searchStr=Firefox%20UI&filter-tier=1&filter-tier=2&filter-tier=3
|
|
||
Updated•7 years ago
|
Flags: needinfo?(ryanvm)
|
|
||
Updated•7 years ago
|
Whiteboard: [stockwell disable-recommended] → [stockwell fixed:other]
|
||
Updated•7 years ago
|
status-firefox55:
--- → unaffected
status-firefox-esr52:
--- → unaffected
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•