1401029 - Linux - Firefox crashes when right-click on Flash content

Status: RESOLVED WONTFIX

(Core Graveyard :: Plug-ins, defect, P2)

Description

[Jeromie Clark]

PASS: Nightly 55.0a1 + Index of /2017/06/2017-06-01-10-02-20-mozilla-central/firefox-55.0a1.en-US.linux-i686.tar.bz2
FAIL: Nightly 55.0a1 + Index of /2017/06/2017-06-02-10-01-43-mozilla-central/ firefox-55.0a1.en-US.linux-i686.tar.bz2 (This is the injection daily build)
PASS: Nightly 55.0a1 + Index of /2017/06/2017-06-08-15-03-02-date/ firefox-55.0a1.en-US.linux-x86_64.tar.bz2
FAIL: Nightly 55.0a1 + Index of /2017/06/2017-06-09-15-03-00-date/ firefox-55.0a1.en-US.linux-x86_64.tar.bz2 (This is the injection daily build)
FAIL: OpenSuSE + Firefox 55.0.1 + 27.0.0.108 & 11.2.202.632
FAIL: OpenSuSE + Firefox 55.0 + 27.0.0.108 
(This is the Firefox injection build 55.0)

FAIL: Ubuntu + Firefox 55.0.1 & Firefox 55.0 + 27.0.0.108 
FAIL: Linuxmint + Firefox 55.0.1 & Firefox 55.0 + 27.0.0.110
PASS: OpenSuSE + Firefox 54.0.1 + 27.0.0.108
PASS: Ubuntu + Firefox 54.0.1 + 27.0.0.108
PASS: Linuxmint + Firefox 54.0.1 + 27.0.0.110
PASS: Fedora + Firefox 55.0.1 + 27.0.0.110

Note: Firefox55.0.1 is the latest version in recently.

Problem:
Firefox crashed when right click in flash content

Method:
1. Download and Install the FP build.
2. Open the Firefox browser and go to http://www.homestarrunner.com/
3. Right click the flash content.

Result:
Firefox crashed when right click in flash content

Expected:
The context menu should be displayed and no crash with Firefox.

Analysis: 

Tested with locally built mozilla firefox from source, I can get the following callstack:

#0 0x00007f5051ddfca1 in gdk_window_get_window_type () at /home/xzhang/opensource/firefox/mozilla-central/widget/gtk/mozgtk/mozgtk.c:523
#1 0x00007f5046403993 in gtk_grab_add () from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
#2 0x00007f504640efa0 in gtk_menu_popup () from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
#3 0x00007f503acbd5eb in ContextMenuEventLoop::DisplayMenu (this=0x7ffec3e4dec0, menu=0x7f5030f790b0, pos=0x7ffec3e4df80)
at ../../../../flash/platform/unix/unixmenu.cpp:318
4 - #12 are flash player callstack
#13 0x00007f504da8f322 in mozilla::plugins::PluginInstanceChild::AnswerNPP_HandleEvent (this=0x7f5040480000, event=..., handled=0x7ffec3e4ed10)
[....]

The crash point is "mozgtk.c:523", which contains the following code:

STUB(gdk_window_get_window_type)
STUB is defined as:
#define STUB(symbol) MOZ_EXPORT void symbol (void)
{ MOZ_CRASH(); }

This means that the crash is triggered on purpose by firefox through "MOZ_CRASH".

What we don't understand is that why Mozilla forces crash for GTK function gtk_grab_add calls "gdk_window_get_window_type()"?

Comment 1

[Tracy Walker [:tracy]]

This works for me with latest Nightly 58.0a1, 20171010100200 on Ubuntu 64-bit Linux 17.04 with Shockwave Flash 27.0.0.159.

Comment 2

[alex_mayorga]

https://www.adobe.com/products/flashplayer/end-of-life.html