1401045 - Considering adding telemetry for when we fail to load a non-favicon image for Highlights/Pocket

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Activity Stream, enhancement, P3)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

In Pocket and Highlights on the top sites panel, we parse the page to get a nice image from it and then use these images to replace the favicon on the top sites panel. However, this attempt can fail because sometimes we parse an invalid url (or the network is down, etc.). In bug 1400397, we added work-around code so that Picasso doesn't retry every time the image is shown (without this patch, there is a pop-in when the Picasso requests the image, can't find it, and replaces it with a placeholder, then you scroll the view offscreen, scroll it back onscreen, and the request starts again).

It'd be good to get telemetry to count the number of times we fail to load images so that we can understand how widespread the problem of failing requests is and if it's worth investigating further (e.g. maybe we're extracting really bad image urls).

Further discussion in bug 1400397 comment 7.

Comment 1

[Chenxia Liu [:liuche]]

This is a pretty rare case as far as we've seen - not a dealbreaker, but nice to have this telemetry so we can see how common this is.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

All open Activity Stream bugs are moving from the whiteboard tag, "[mobileAS]", to the Firefox for Android component, "Activity Stream", so that I can keep better track of these bugs as the new triage owner; I will send out an email shortly with additional details, caveats, etc.

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.