Closed Bug 1401071 Opened 7 years ago Closed 7 years ago

Fix nits for mp4parse_fallible

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: ayang, Assigned: ayang)

References

Details

Attachments

(1 file)

There are several nits need to be fixed in orevisou PRs including:


. move mp4parse_fallible out of mp4parser
. use 'feature' to control fallible memory allocation
. remove redundant error code TableTooLarge
. rename reserve_read_buf to allocate_read_buf
Comment on attachment 8911634 [details]
Bug 1401071 - move fallible memory allocation github instead of including source and other nits.

https://reviewboard.mozilla.org/r/183034/#review188196
Attachment #8911634 - Flags: review?(kinetik) → review+
Priority: -- → P3
Pushed by ayang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/edae6c684c0e
move fallible memory allocation github instead of including source and other nits. r=kinetik
https://hg.mozilla.org/mozilla-central/rev/edae6c684c0e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Did you want to request Beta approval on this to fix bug 1389527?
Blocks: 1389527
Flags: needinfo?(ayang)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #9)
> Did you want to request Beta approval on this to fix bug 1389527?

No, it is an invalid mp4 stream, current train is good enough.
Flags: needinfo?(ayang)
You need to log in before you can comment on or make changes to this bug.