1401085 - Different color is used for disabled back/forward arrows in toolbar (especially with Compact Density)

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Tooru Fujisawa [:arai]]

Attachment: back/forward arrows on Compact Density

Steps to Reproduce:
  1. run Nightly 57.0a1 (2017-09-18) (64-bit) with clean profile
  2. start customize
  3. set to Compact Density
  4. finish customize

Actual result:
  while customizing, forward arrow is darker
  after customizing, back arrow is darker

Expected result:
  both arrows has same color
  (note that there's no history and both arrows are disabled)

actually the same color difference applies on Normal Density, but it's nor obvious on Compact Density, since there's no circle on back arrow.

also, the color difference also happens on Dark theme, with inverted brightness.

Comment 1

[Tooru Fujisawa [:arai]]

(In reply to Tooru Fujisawa [:arai] from comment #0)
> actually the same color difference applies on Normal Density, but it's nor
> obvious on Compact Density, since there's no circle on back arrow.

it's *more* obvious

Comment 2

[:Gijs (out for now; he/him)]

I suspect they're getting different opacity because of 2 conflicting CSS rules.

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1401085 - Make the opacity of the disabled back button consistent with other disabled toolbar buttons.

Review commit: https://reviewboard.mozilla.org/r/181974/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181974/

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8910536 [details]
Bug 1401085 - Make the opacity of the disabled back button consistent with other disabled toolbar buttons.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/181974/diff/1-2/

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8910536 [details]
Bug 1401085 - Make the opacity of the disabled back button consistent with other disabled toolbar buttons.

https://reviewboard.mozilla.org/r/181974/#review187528

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f5e6917b9af
Make the opacity of the disabled back button consistent with other disabled toolbar buttons. r=dao

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1f5e6917b9af

Comment 9

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8910536 [details]
Bug 1401085 - Make the opacity of the disabled back button consistent with other disabled toolbar buttons.

Approval Request Comment
[Feature/Bug causing the regression]: photon-visual polish
[User impact if declined]:  back button icon colour is not consistent with other toolbar buttons
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: minor css change
[String changes made/needed]: none

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8910536 [details]
Bug 1401085 - Make the opacity of the disabled back button consistent with other disabled toolbar buttons.

Photon polish, taking it.
Should be in 57b4!

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/38f4bb54aa79

Comment 12

[Valentina Claudia Ona]

I verify this issue using Latest Nightly 58.0a1 with Build ID 20171006100327 on Mac OS X 10.12.
I will mark this as verified fixed.

Comment 13

[Valentina Claudia Ona]

I also verified this issue using Latest Firefox Beta 57.0b9 and Nightly 58.0a1 with Build ID  20171016185129 on Windows 10 x64 and Mac OS 10 X 12
I can confirm the fix.