Closed
Bug 1401092
Opened 7 years ago
Closed 5 years ago
Pocket doorhanger isn't RTL compatible
Categories
(Firefox :: Pocket, defect, P3)
Firefox
Pocket
Tracking
()
RESOLVED
FIXED
People
(Reporter: ehsan.akhgari, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: rtl)
Attachments
(1 file)
|
90.33 KB,
image/png
|
Details |
Screenshot
See the screenshot from the latest Persian nightly for example. All of the strings are displayed incorrectly because the containing elements don't have the correct direction set on them.
|
||
Comment 1•7 years ago
|
||
Can you test an older build, like 56 or something? I kind of doubt this is a recent regression... I'd use mozregression but that doesn't get me localized builds.
Flags: needinfo?(ehsan)
|
|
||
Comment 3•7 years ago
|
||
Eh, never mind, bug 137995 is filed against release, so yes this is older.
While I would like this to make 57, I have no cycles and because this isn't a regression, realistically this doesn't need to be P1.
That said, if someone wants to make a patch, what I think needs to happen is:
- modify this block:
https://dxr.mozilla.org/mozilla-central/rev/11fe0a2895aab26c57bcfe61b3041d7837e954cd/browser/extensions/pocket/content/main.js#493-507
to also be passed a 'dir' variable based on the UI direction.
- modify signup.js and saved.js in pocket to set the dir on the <html> element.
I *think* that might be enough, but we may need to flip some of the images, so this will need some more testing and potentially some tweaking in the stylesheets as well.
|
Reporter | |
Comment 4•7 years ago
|
||
This isn't a recent regression, but assigning P3 to it (which as I understand meant it won't get fixed unless if someone would be kind enough to provide a patch) is a huge understatement of the severity of this bug for RTL locales, for the record.
This is part of our primary UI for four of our locales. Currently the text that we display in this UI is just unreadable gibberish. It is quite unprofessional to distribute builds like that to the users on these four locales. I think the only reason why we have gotten away with doing that for so many releases so far is that we don't do proper QA for RTL locales.
I very much think we should fix this in the next release of Firefox going out. My $0.02, at least.
|
|
||
Comment 5•7 years ago
|
||
(In reply to :Ehsan Akhgari (needinfo please, extremely long backlog) from comment #4)
> This isn't a recent regression, but assigning P3 to it (which as I
> understand meant it won't get fixed unless if someone would be kind enough
> to provide a patch) is a huge understatement of the severity of this bug for
> RTL locales, for the record.
The only choices I have right now are P1 (it gets fixed for 57) or P3 (it doesn't).
I don't have cycles to do this for 57, nor does anyone else I know, so P1 would just be fiction unless someone steps up to do the work. Given that it was also broken in 56 (and, I expect, 55, and 54, and...) I don't think it makes sense to deprioritize other work that is in desperate need of engineering attention in favour of this bug. If you know someone with cycles or have evidence that this is a recent regression, feel free to ping me.
Fixed by bug 1279230 and bug 1594833.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•