Remove redundant code from CGI.pl

RESOLVED FIXED in Bugzilla 2.16

Status

()

Bugzilla
Bugzilla-General
--
blocker
RESOLVED FIXED
16 years ago
5 years ago

People

(Reporter: gerv, Assigned: gerv)

Tracking

({perf})

2.15
Bugzilla 2.16

Details

Attachments

(1 attachment)

12.83 KB, patch
David D. Kilzer (ddk)
: review+
David D. Kilzer (ddk)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

16 years ago
Post-templatisation, there is a _load_ of redundant code in CGI.pl that no-one
uses. Given that this file is instantiated every time we run a CGI, removing it
all must be a perf win of some sort. And it also makes what's going on a lot
clearer.

Gerv
(Assignee)

Comment 1

16 years ago
Accepting.

Gerv
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.16
(Assignee)

Comment 2

16 years ago
Created attachment 81011 [details] [diff] [review]
Patch v.1

Remove 273 lines of rubbish from CGI.pl.

Gerv

Updated

16 years ago
Keywords: patch, perf, review

Comment 3

16 years ago
Comment on attachment 81011 [details] [diff] [review]
Patch v.1

2xr=ddk  Grepped for removed functions after patching CGI.pl, but
couldn't find any.

[NIT]  Regarding make_options(), there is a comment about it in
query.cgi, but I don't think the comment is valid anymore (but
I'm not sure).	The comment could be updated.
Attachment #81011 - Flags: review+
(Assignee)

Comment 4

16 years ago
Fixed. Excellent :-)

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.147; previous revision: 1.146
done

Gerv
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.