Closed
Bug 140110
Opened 23 years ago
Closed 23 years ago
Remove redundant code from CGI.pl
Categories
(Bugzilla :: Bugzilla-General, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: gerv, Assigned: gerv)
Details
(Keywords: perf)
Attachments
(1 file)
|
12.83 KB,
patch
|
ddkilzer
:
review+
ddkilzer
:
review+
|
Details | Diff | Splinter Review |
Post-templatisation, there is a _load_ of redundant code in CGI.pl that no-one
uses. Given that this file is instantiated every time we run a CGI, removing it
all must be a perf win of some sort. And it also makes what's going on a lot
clearer.
Gerv
|
Assignee | |
Comment 1•23 years ago
|
||
Accepting.
Gerv
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.16
|
|
Assignee | |
Comment 2•23 years ago
|
||
Remove 273 lines of rubbish from CGI.pl.
Gerv
|
||
Updated•23 years ago
|
|
|
||
Comment 3•23 years ago
|
||
Comment on attachment 81011 [details] [diff] [review]
Patch v.1
2xr=ddk Grepped for removed functions after patching CGI.pl, but
couldn't find any.
[NIT] Regarding make_options(), there is a comment about it in
query.cgi, but I don't think the comment is valid anymore (but
I'm not sure). The comment could be updated.
Attachment #81011 -
Flags: review+
|
|
Assignee | |
Comment 4•23 years ago
|
||
Fixed. Excellent :-)
Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v <-- CGI.pl
new revision: 1.147; previous revision: 1.146
done
Gerv
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•