Post-templatisation, there is a _load_ of redundant code in CGI.pl that no-one uses. Given that this file is instantiated every time we run a CGI, removing it all must be a perf win of some sort. And it also makes what's going on a lot clearer. Gerv
Created attachment 81011 [details] [diff] [review] Patch v.1 Remove 273 lines of rubbish from CGI.pl. Gerv
Comment on attachment 81011 [details] [diff] [review] Patch v.1 2xr=ddk Grepped for removed functions after patching CGI.pl, but couldn't find any. [NIT] Regarding make_options(), there is a comment about it in query.cgi, but I don't think the comment is valid anymore (but I'm not sure). The comment could be updated.
Fixed. Excellent :-) Checking in CGI.pl; /cvsroot/mozilla/webtools/bugzilla/CGI.pl,v <-- CGI.pl new revision: 1.147; previous revision: 1.146 done Gerv