1401183 - Return KeyError from list_artifacts when none is found

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

Instead of a requests error that might also be transient.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1401183: raise KeyError from list_artifacts when none is found;

Review commit: https://reviewboard.mozilla.org/r/181264/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181264/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8909767 [details]
Bug 1401183: raise KeyError from list_artifacts when none is found;

https://reviewboard.mozilla.org/r/181264/#review187000

::: commit-message-e4261:1
(Diff revision 1)
> +Bug 1401183: return KeyError from list_artifacts when none is found; r?glandium

s/return/raise/

::: taskcluster/taskgraph/util/taskcluster.py:90
(Diff revision 1)
>  def find_task_id(index_path, use_proxy=False):
> +    try:
> -    response = _do_request(get_index_url(index_path, use_proxy))
> +        response = _do_request(get_index_url(index_path, use_proxy))
> +    except requests.exceptions.HTTPError as e:
> +        if e.response.status_code == 404:
> +            raise KeyError

you should raise an instance, not the class.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8909767 [details]
Bug 1401183: raise KeyError from list_artifacts when none is found;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/181264/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83fdd1638d8e
raise KeyError from list_artifacts when none is found; r=glandium

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/83fdd1638d8e