Closed
Bug 140121
Opened 23 years ago
Closed 23 years ago
We need to start calling SyncAnyPendingShadowChanges again
Categories
(Bugzilla :: Bugzilla-General, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: gerv, Assigned: gerv)
Details
Attachments
(1 file)
|
1.03 KB,
patch
|
myk
:
review+
myk
:
review+
|
Details | Diff | Splinter Review |
PutFooter() calls SyncAnyPendingShadowChanges. The footer template doesn't. When PutFooter() goes away entirely, this function will never get called. That's probably bad. Gerv
|
Assignee | |
Comment 1•23 years ago
|
||
Fix - call it in the template, and add a reference in globals.pl. Gerv
|
|
Assignee | |
Comment 2•23 years ago
|
||
Targetting at 2.16 - this could well be a perf issue. Gerv
Severity: normal → critical
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.16
|
||
Comment 3•23 years ago
|
||
Comment on attachment 81016 [details] [diff] [review] patch v.1 works, trivial. 2xr=myk
Attachment #81016 -
Flags: review+
|
|
Assignee | |
Comment 4•23 years ago
|
||
Fixed. Checking in template/en/default/global/footer.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/footer.html.tmpl,v <-- footer.html.tmpl new revision: 1.3; previous revision: 1.2 done Checking in globals.pl; /cvsroot/mozilla/webtools/bugzilla/globals.pl,v <-- globals.pl new revision: 1.159; previous revision: 1.158 done Gerv
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•