1401225 - EditorBase::SetTextImpl() uses the wrong length when collapsing the selection

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[(no longer active)]

I discovered this because of try server failures of my patch for bug 1399722.  Before that patch we didn't run this block of code, but the length I was passing here is wrong: <https://searchfox.org/mozilla-central/rev/1c13d5cf85f904afb8976c02a80daa252b893fca/editor/libeditor/EditorBase.cpp#2749>

This length is set in the beginning of the function to the length of the old text content of the text node <https://searchfox.org/mozilla-central/rev/1c13d5cf85f904afb8976c02a80daa252b893fca/editor/libeditor/EditorBase.cpp#2716>

But then we modify the text content here: <https://searchfox.org/mozilla-central/rev/1c13d5cf85f904afb8976c02a80daa252b893fca/editor/libeditor/EditorBase.cpp#2741>

The old code used to do the right thing: <https://hg.mozilla.org/integration/mozilla-inbound/rev/baeb2b439c08#l3.61>

Comment 1

[Julien Cristau [:jcristau]]

tracking as new regression in 57

Comment 2

[(no longer active)]

Attachment: Pass the correct length when collapsing the selection in EditorBase::SetTextImpl()

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d924f659b8c
Pass the correct length when collapsing the selection in EditorBase::SetTextImpl(); r=masayuki

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4d924f659b8c