Closed Bug 1401288 Opened 4 years ago Closed 4 years ago

Ensure that the WebExtensions "devtools panel" browsers run in the same TabGroup of the other extension pages

Categories

(WebExtensions :: Developer Tools, enhancement, P2)

enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: rpl, Assigned: rpl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In the ext-devtools-panel.js API module, we are creating the browser elements that are going to load the "devtools panel" extension pages, and the `sameProcessAsFrameLoader` property of these browser elements should be set to the extension.groupFrameLoader as we are currently doing for other extension browser elements like for the popups:

- http://searchfox.org/mozilla-central/rev/1c13d5cf85f904afb8976c02a80daa252b893fca/browser/components/extensions/ExtensionPopups.jsm#242
Attachment #8909918 - Flags: review?(aswan)
Assignee: nobody → lgreco
Blocks: webext-oop
Status: NEW → ASSIGNED
Priority: -- → P2
Comment on attachment 8909918 [details]
Bug 1401288 - Run remote devtools panel browsers in the right TabGroup.

https://reviewboard.mozilla.org/r/181400/#review186700
Attachment #8909918 - Flags: review?(aswan) → review+
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/3e84d38ad0b4
Run remote devtools panel browsers in the right TabGroup. r=aswan
https://hg.mozilla.org/mozilla-central/rev/3e84d38ad0b4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Flags: qe-verify-
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.