1401291 - JS files should pass linting

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Code Cleanup, enhancement)

Description

[Stephanie Hobson [:shobson]]

We have ESLint configured now and it even runs on a pre-commit hook \o/

All our files should pass ESLint. That is a benifit by itself. However, if all files are passing then the pre-commit hook will be more useful because any errors it identifies will be new.

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/1c61194abc14a326ab4e5d9af0b37da2f8432afd
Fix Bug 1401291, fixes badges.js and component.js

https://github.com/mozilla/kuma/commit/8f41629afbd1e0bd7146ba2164529d65e7cdda26
Merge pull request #4545 from schalkneethling/bug1401291-js-files-should-pass-linting

Fix Bug 1401291, fixes badges.js and component.js

Comment 2

[Schalk Neethling [:espressive]]

Attachment: pr 4552: Fix Bug 1401291, ensure dashboard/font-check/fonts.js passes linting

Comment 3

[Schalk Neethling [:espressive]]

Attachment: pr 4564: Fix Bug 1401291, ensures main and moz-jquery-plugins pass linting

Comment 4

[Schalk Neethling [:espressive]]

Attachment: pr 4565: Fix Bug 1401291, ensure promote.js and users.js pass linting

Comment 5

[Schalk Neethling [:espressive]]

Attachment: pr 4565: Fix Bug 1401291, ensure promote.js and users.js pass linting

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/bde04f8b9e3bae705396bb6ec12bdb151c9b3b3b
Fix Bug 1401291, ensure wiki-move.js pass linting

https://github.com/mozilla/kuma/commit/ef250e9edf1ccbed069129bce8f4c3028c7e0c0b
Merge pull request #4566 from schalkneethling/bug1401291-ensure-wiki-move-pass-linting

Fix Bug 1401291, ensure wiki-move.js pass linting

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/625cb677787165e87b77b5e6c84619c626e523e2
Fix Bug 1401291, ensure promote.js and users.js pass linting

https://github.com/mozilla/kuma/commit/9159518a424cb1d3ddb0e083e6c0c5bc5cd6cbcf
Merge pull request #4565 from schalkneethling/bug1401291-ensure-promote-users-pass-linitng

Fix Bug 1401291, ensure promote.js and users.js pass linting

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/f652c14098b18000a6f297b214be8bb90adc1e3e
Fix Bug 1401291, ensure dashboard/font-check/fonts.js passes linting

https://github.com/mozilla/kuma/commit/b2f071a806af70e4f1678b702f4d6b08e45617a7
Merge pull request #4552 from schalkneethling/bug1401291-ensure-dashboard-fontcheck-fonts-js-pass-linting

Fix Bug 1401291, ensure dashboard/font-check/fonts.js passes linting

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/6185b990e5c24791337327e1e4789d15d4869e8f
Fix Bug 1401291, ensures main and moz-jquery-plugins pass linting

https://github.com/mozilla/kuma/commit/7325fa9137e37662ceb7f2f73677d4ddcc31abbd
Merge pull request #4564 from schalkneethling/bug1401291-ensure-main-moz-jquery-plugins-pass-linting

Fix Bug 1401291, ensures main and moz-jquery-plugins pass linting

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/7919971761376cd9ea9a68f09c7a9f50f71b5766
Fix bug 1401291: pass linting (#4596)

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/dc4a740d20e3feb2896f8c14affc72c547bcb027
Fix Bug 1401291, change warnings to error - eslint

https://github.com/mozilla/kuma/commit/65b6438300d4ca631347f36bdf09099d271d62e8
Merge pull request #4597 from schalkneethling/bug1401291-switch-eslint-to-error

Fix Bug 1401291, change warnings to error - eslint