1401316 - Use favicon from either https or http version of the page

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Ed Lee :Mardak]

Pages that redirect have no favicon. This will get worse when we have rich icons when we could have shown something much better.

Comment 1

[Ed Lee :Mardak]

Attachment: fixed

Comment 2

[Ed Lee :Mardak]

Attachment: Bug 1401316 - Use favicon from either https or http version of the page.

Review commit: https://reviewboard.mozilla.org/r/181430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181430/

Comment 3

[Ursula Sarracini (:ursula)]

Comment on attachment 8909955 [details]
Bug 1401316 - Use favicon from either https or http version of the page.

https://reviewboard.mozilla.org/r/181430/#review186694

Thanks Ed!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26f9c5c3f434
Use favicon from either https or http version of the page. r=ursula

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing xpcshell's toolkit/modules/tests/xpcshell/test_NewTabUtils.js:

https://hg.mozilla.org/integration/autoland/rev/bb2d70186f6e6c1d9bd6313def70acc1ee8c5487

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=26f9c5c3f434500adb3aa7e47c8eebdb9ed45c86&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=132058397&repo=autoland

14:08:03     INFO -  TEST-PASS | toolkit/modules/tests/xpcshell/test_NewTabUtils.js | getHighlights - [getHighlights : 485] history is now the first, i.e., most recent, bookmark - "http://mozilla.com/" == "http://mozilla.com/"
14:08:03     INFO -  TEST-PASS | toolkit/modules/tests/xpcshell/test_NewTabUtils.js | getHighlights - [getHighlights : 486] was history now bookmark - "bookmark" == "bookmark"
14:08:03     INFO -  TEST-PASS | toolkit/modules/tests/xpcshell/test_NewTabUtils.js | getHighlights - [getHighlights : 487] still have younger bookmark now second - "https://mozilla1.com/nowNew" == "https://mozilla1.com/nowNew"
14:08:03     INFO -  TEST-PASS | toolkit/modules/tests/xpcshell/test_NewTabUtils.js | getHighlights - [getHighlights : 488] still have older bookmark now third - "https://mozilla1.com/dayOld" == "https://mozilla1.com/dayOld"
14:08:03     INFO -  TEST-PASS | toolkit/modules/tests/xpcshell/test_NewTabUtils.js | getHighlights - [getHighlights : 492] We're not expecting a change in links - 3 == 3
14:08:03  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/modules/tests/xpcshell/test_NewTabUtils.js | getHighlights - [getHighlights : 495] Link 1 should contain a favicon - false == true
14:08:03     INFO -  /Users/cltbld/tasks/task_1505847776/build/tests/xpcshell/tests/toolkit/modules/tests/xpcshell/test_NewTabUtils.js:getHighlights:495
14:08:03     INFO -  exiting test
14:08:03     INFO -  Unexpected exception 2147500036
14:08:03     INFO -  undefined
14:08:03     INFO -  exiting test

Comment 6

[Ed Lee :Mardak]

Doh. Tests failed from other stuff on autoland. Updating tests.

Comment 7

[Ed Lee :Mardak]

Comment on attachment 8909955 [details]
Bug 1401316 - Use favicon from either https or http version of the page.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/181430/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c55a11aac9cd
Use favicon from either https or http version of the page. r=ursula

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c55a11aac9cd