Closed
Bug 140136
Opened 23 years ago
Closed 23 years ago
clean up ShowProgressDialog() and friends
Categories
(Core Graveyard :: Embedding: APIs, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.1alpha
People
(Reporter: alecf, Assigned: alecf)
Details
Attachments
(1 file)
9.30 KB,
patch
|
mikepinkerton
:
review+
bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
nsExternalHelperAppService has some wacky state going on with
ShowProgressDialog()/etc
really we just need to rename some of the state variables, and call
ShowProgressDialog something like CreateProgressListener()
patch forthcoming
Assignee | ||
Comment 1•23 years ago
|
||
this came out of bug 134523, which has a band-aid fix that I'm repairing with
this bug.
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla1.1alpha
Assignee | ||
Comment 2•23 years ago
|
||
ok, here's what I've done:
1) moved initialization of the nsIDownload object into a seperate method,
InitializeDownload() which we only call when the object has actually been
created.
1a) still call SetWebProgressListener() - the function was already designed to
be called with a null parameter, now we might actually do it.
2) renamed ShowProgressDialog to CreateProgressListener
3) renamed mProgressWindowCreated to mProgressListenerInitialized to more
accurately reflect the state of the world - its not necessarily a dialog, and
we don't necessarily have one, but we might have attempted it, so we call that
"initialized"
4) cleaned up dependencies - we no longer depend on nsIProgressDialog.h
5) packed some booleans, reducing the size of the object by 12 bytes :)
reviews?
Comment 3•23 years ago
|
||
Comment on attachment 81042 [details] [diff] [review]
cleanup - rename methods, rearrange some code
r=pink
Attachment #81042 -
Flags: review+
I'm applying the patch to see if it fixes bug 56379...
Assignee | ||
Comment 5•23 years ago
|
||
no, it won't fix that. It really has nothing to do with that bug.
Comment 6•23 years ago
|
||
Though Pink already reviewed it, looks good to me too.
> 5) packed some booleans, reducing the size of the object by 12 bytes :)
On some platforms anyway - On the PowerPC, we're using 4-byte alignment. We get
no love from the PRPackedBool.
Comment 7•23 years ago
|
||
Comment on attachment 81042 [details] [diff] [review]
cleanup - rename methods, rearrange some code
sr=blake
Attachment #81042 -
Flags: superreview+
Assignee | ||
Comment 8•23 years ago
|
||
I _finally_ got around to landing this.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
If this is supposed to resolve the downloading problem in MFCEmbed, the problem
is still there. I just tested downloading with the June 4, 2002 nightly build of
MFCEwmbed and no dialog shows up when downloading.
Comment 11•22 years ago
|
||
verified patch against Mozilla 1.2b Mozilla/5.0 (Windows; U; WinNT4.0; en-US;
rv:1.2b) Gecko/20021026 build.
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•