1401460 - ChannelMediaResource should update principals in OnStartRequest()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

Per discussion with schien and roc, OnStartRequest() always happens after AsyncOnChannelRedirect() which is the last chance for a channel to change its domain and principal.

So we should update principals for the resource in OnStartRequest() instead of each OnDataAvailable() call.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1401460 - update principals in OnStartRequest().

See comment 0 for the rationale.
The principal will not change after OnStartRequest().

Review commit: https://reviewboard.mozilla.org/r/181648/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181648/

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8910155 [details]
Bug 1401460 - update principals in OnStartRequest().

https://reviewboard.mozilla.org/r/181648/#review187014

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d74f41e43065
update principals in OnStartRequest(). r=gerald

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d74f41e43065