1401517 - Allow Super Search query filtering for product version greater-than or less-than a given version

Status: RESOLVED FIXED

(Socorro :: General, enhancement, P2)

Description

[Jonathan Watt [:jwatt]]

I'd like to be able to ignore all crash reports from versions of Firefox prior to a given version number. Since you can use version=X in the query string to filter on a specific version I was hopeful that you could also use version>=X to return results for version X and above. Unfortunately that doesn't seem to work.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

The "version" field is stored as a keyword, so it's not comparable. You can't say "I want all versions less than xyz" using the "version" field.

The list of versions is finite. Can you generate a value for either all the versions you do want or all the ones you don't want and use that? You can get the list of versions for Firefox that Socorro knows about using this API endpoint:

https://crash-stats.mozilla.com/api/ProductVersions/?product=Firefox

Can you use the BuildID field? That's date-based and supports comparators:

https://crash-stats.mozilla.org/documentation/supersearch/api/#param-build_id

Comment 2

[Jonathan Watt [:jwatt]]

Could the code that acts on the query string parameters not do exactly that? Given how the "version" field is implemented, it makes sense that it can't naively translate version>=X into a greater-than-or-equal SQL query (or whatever). But it could do the work to translate it into a set of version numbers, no?

It would be preferable if Socorro did this translation so that it's possible to create URLs that can be distributed to other devs and used by a team over a period of time without having to constantly update them as new versions, betas, point releases, etc. are made.

Comment 3

[Jonathan Watt [:jwatt]]

I'll investigate the use of the BuildID field as a workaround for now.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

I agree that it'd be great if Socorro worked better for this use case.

If anyone else has a similar need, please add a comment with your specific use case so we have a better idea of what we need to solve and how best to solve it.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Just as an update, the ProductVersions API endpoint is gone now, so using that isn't possible anymore.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this to work on.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5745: bug 1111612, 1401517: add major_version and make it searchable

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5745: "bug 1111612, 1401517: add major_version and make it searchable" in eb59776.

This will deploy to stage in a few minutes. I'll push it to prod this week.

However, because it requires data in Elasticsearch, it'll be at least a week before this is usable at all and (depending on needs) a few weeks until this is useful. But then after that, this should be pretty cool.

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

I tested this in prod today and it works great. Marking as FIXED.