1401523 - Bookmark items are missing vertical padding on Windows

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1401523 - Add 1px vertical padding to bookmark items.

Review commit: https://reviewboard.mozilla.org/r/181740/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181740/

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8910250 [details]
Bug 1401523 - Add 1px vertical padding to bookmark items.

https://reviewboard.mozilla.org/r/181740/#review187088

Tested on Windows 10, it appears coherent with the mock-ups.

Comment 3

[Marco Bonardo [:mak]]

As a side note, bug 1391593 moved the bookmarks up by 1px compared to the mock-up, it may be wanted or not. Based on that bug it should be centered so it's wanted.

As a final note, 2px 4px (insteaf of 1px 4px) of padding looks many times better. But that's something for Stephen to evaluate :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e19b6a153a6
Add 1px vertical padding to bookmark items. r=mak

Comment 7

[Edo Karabas]

So I have tested the patch and looks perfect for all densities. All of the sudden it solves all remaining "issues" from bug 1388794. So bug 1388794 is now completely fixed. Thanks!
The biggest visible issue for Bookmark toolbar remains in bug 1363028, which is unfortunately without activity for a month. It is sad since for example folder icons are currently still from Australis era.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5e19b6a153a6

Comment 9

[Valentina Claudia Ona]

I verified this issue on Windows 10 x64 and Windows 7 x64 using Nightly 58.0a1 and Firefox Beta 57.0b3 with Build ID 20170926220106 and Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0.
I will mark this as verified fixed.