1401548 - Migrate browser_bug_869003_inspect_cross_domain_object.js to new console

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

The test ensure we can inspect objects from iframes.
The VariableView part should be migrated to use the ObjectInspector instead.

Comment 1

[Julian Descottes [:jdescottes]]

The ni? fired without letting me write my comment :)

My question was: I'm migrating the test, but part of it is asserting the "edit" features of the Variables View. 
We can either:
- migrate right now and only check that cross domain properties can be read
- wait for the new Variables View -like feature to be implemented and migrate then (provided edit features will be supported there)

What do you think?

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1401548 - rename and enable browser_bug_869003_inspect_cross_domain_object.js;

Review commit: https://reviewboard.mozilla.org/r/203922/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203922/

Comment 3

[Julian Descottes [:jdescottes]]

Patch + try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff34e0a8e11fe4a35db96f2fa1f814f60ebf4d5f

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

I think we can migrate it right now. If we implement edit-in-objectInspector at some point, we'll write the tests.
I don't expect to have edit in OI soon (i'd like to think more about this interaction)

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8932915 [details]
Bug 1401548 - rename and enable browser_bug_869003_inspect_cross_domain_object.js;

https://reviewboard.mozilla.org/r/203922/#review209412

This looks good, thanks Julian !

Comment 6

[Julian Descottes [:jdescottes]]

Comment on attachment 8932915 [details]
Bug 1401548 - rename and enable browser_bug_869003_inspect_cross_domain_object.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203922/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/897dda0b93d8
rename and enable browser_bug_869003_inspect_cross_domain_object.js;r=nchevobbe

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/897dda0b93d8