1401584 - Invalid entry inside "Extensions" for failed drag and drop installation

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[marius.santa]

Attachment: donloaded.gif

[Affected versions]:
Firefox 57.0a1 (20170919220202)

[Affected platforms]:
Windows 10 64-bit
Mac Os X 10.12.3


[Steps to reproduce]:
1.Launch Firefox with a clean profile.
2.Drag and drop: https://drive.google.com/open?id=0BzeXJUlmIt_lSnBZU2swR3FEU1E onto the browser.
4.Press "CTRL+SHIFT+a" .
5.Click on "Extensions".


[Expected Results]:
The legacy add-on is not displayed inside the "Extensions" or "Legacy Extensions" tabs.


[Actual Results]:
The legacy add-on is displayed with an invalid download progress bar.
-see attached screencast

Notes:
The legacy add-on "Downloaded" entry is displayed inside the "Extensions" tab until the browser is restarted, a page refresh will not dismiss it.

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1401584 Properly cancel local installs of incompatible extensions

Review commit: https://reviewboard.mozilla.org/r/182844/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182844/

Comment 2

[Robert Helmer [:rhelmer]]

Comment on attachment 8911368 [details]
Bug 1401584 Properly cancel local installs of incompatible extensions

https://reviewboard.mozilla.org/r/182844/#review189264

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad2e7c189a20
Properly cancel local installs of incompatible extensions r=rhelmer

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ad2e7c189a20

Comment 5

[marius.santa]

Attachment: handeling unsupported webext.gif

This bug is verified on Firefox 58.0a1 (20170928220658) under Windows 10 64-bit and Mac OS X 10.12.3.

The label on the "Available Updates" section is displayed with the correct number of updates.

Please see the attached screenshot.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

I guess we want this to ride the trains with 58, right?

Comment 7

[Andrew Swan [:aswan]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #6)
> I guess we want this to ride the trains with 58, right?

Yeah, I don't think there's any compelling reason to uplift this.