1401613 - Stop requiring test type in expectation metadata

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement)

Description

[James Graham [:jgraham]]

This is unnecessary since we can look them up in the manifest and causes problems since it isn't required to run tests but only during update.

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1401613 - Don't require test type in wpt expectation manifest,

The test type is already in the MANIFEST.json file and requiring it in
the expectation data doesn't make much sense. It isn't used execpt
during updates and so people often forget to add it. Therefore it
makes a lot of sense to just use the data from the main manifest.

Review commit: https://reviewboard.mozilla.org/r/181834/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181834/

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8910391 [details]
Bug 1401613 - Don't require test type in wpt expectation manifest,

https://reviewboard.mozilla.org/r/181834/#review187232

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9192c6646cec
Don't require test type in wpt expectation manifest, r=maja_zf

Comment 4

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

Backed out bug 1402002, bug 1401613 and bug 1402123 for perma-crashing in wpt /css/css-variables-1/variable-first-letter.html on Linux 32 stylo disabled debug and still failing wpt /mediacapture-streams/MediaStream-MediaElement-preload-none.https.html on non-stylo builds. r=backout a=backout

Bug 1402002
https://hg.mozilla.org/mozilla-central/rev/82b2ae0b03ca1d99d1fe6a9944c450dba3b2bc97
https://hg.mozilla.org/mozilla-central/rev/07157f6ed327ad2533214efe1d4fc7249c51b02c

Bug 1401613
https://hg.mozilla.org/mozilla-central/rev/5b815c394dcbb150b3be056a2a1db42f08b475d2

Bug 1402123
https://hg.mozilla.org/mozilla-central/rev/8b9bbaf899940f4ec673e1e00c5c44db3023a8c7

See the wpt failures of this recent autoland push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=5a63d8457a2a69a2ad54a50765bff412580df2a4&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7aad92c4e7f
Don't require test type in wpt expectation manifest, r=maja_zf

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f7aad92c4e7f