1401632 - Intermittently missing twitter and facebook favicons on pinned tabs

Status: RESOLVED DUPLICATE of bug 1405253

(Firefox :: Tabbed Browser, defect)

Description

[:gerard-majax]

Since a few days, upon each restart or update application on Nightly, the favicon for Twitter or Facebook pinned tab may be missing.

This happened first a couple (3-4 max) days ago on Nightly. Linux/Ubuntu 17.04. I cannot use mozregression to find more for the moment

Comment 1

[:gerard-majax]

Attachment: Capture d'écran de 2017-09-20 18-58-07.png

Comment 2

[:gerard-majax]

Closing then reloading the pinned tab does not help. Half of the time, restarting the whole browser is enough.

Comment 3

[:gerard-majax]

I should also mention those pinned tabs are in the same container (other pinned tab in the same container do not expose the issue).

Comment 4

[:gerard-majax]

Update: the icon "disappeared" during the night on the Twitter tab. That is, this morning, waking up my laptop from suspend, switching to the nightly window, icon is missing.

Comment 5

[:gerard-majax]

Ed, I had a look at the life of bug 1352459 and the backout/reland dates also match the appearance of the present bug. It also does match with the use of "rich" icons that I saw appearing at the same time of the non-displayed icons. Therefore, I fear this is a regression from your changes, could you have a look?
Thanks!

Comment 6

[Ed Lee :Mardak]

Not entirely sure what's causing them to disappear.. Maybe some image cache kicks out the larger icons? Might get fixed as part of bug 1401777 to use smaller favicons.

Comment 7

[:gerard-majax]

(In reply to Ed Lee :Mardak from comment #6)
> Not entirely sure what's causing them to disappear.. Maybe some image cache
> kicks out the larger icons? Might get fixed as part of bug 1401777 to use
> smaller favicons.

Sure, I'll keep an eye on that :)

Comment 8

[:gerard-majax]

(In reply to Ed Lee :Mardak from comment #6)
> Not entirely sure what's causing them to disappear.. Maybe some image cache
> kicks out the larger icons? Might get fixed as part of bug 1401777 to use
> smaller favicons.

So, it seems bug 1401777 has not landed yet, but I have not had any new occurrence of the issue. Given the reproductibility rate, I fear something else either fixed it (good, even though bad because we don't know what), or it is being masked (very bad). Maybe you have a better view than myself on that ?

Comment 9

[Marco Bonardo [:mak]]

Gijs saw something similar today, and he said the cache was serving a 0-byte file.

Comment 10

[:gerard-majax]

(In reply to Marco Bonardo [::mak] from comment #9)
> Gijs saw something similar today, and he said the cache was serving a 0-byte
> file.

Good to know I'm not the only one hitting that. I'm curious, how could he verify the cache was serving a 0 byte file?

Comment 11

[Pascal Chevrel:pascalc]

bug 1403649 may be a duplicate

Comment 13

[Clément Lefèvre]

I'm experiencing favicon disappearing either, but not on pinned tabs: it's on regular tabs when hovering them.
I'm currently helping investigate bug 1391797 with a try build and thought it might be related. However as of now I don't experience anymore the favicon blinking with this try build while I still have favicons disappearing when hovering tabs.
Network monitor in dev tools doesn't even show the favicon being downloaded (is it supposed to be in the list? I guess yes), even when doing a hard refresh with ctrl/cmd + shift + r.