1401667 - Xcode 9.0 - Foundation NSUUID.h doesn't compile

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Aria Beingessner [:Gankra]]

Just updated Xcode to the latest release, and I can no longer build tip. (whether I'm using ICECC doesn't seem to affect it)

8:29.23 /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSUUID.h:26:49: error: nullability specifier '_Nullable' cannot be applied to non-pointer type 'uuid_t' (aka 'unsigned char [16]')
 8:29.23 - (instancetype)initWithUUIDBytes:(const uuid_t _Nullable)bytes;
 8:29.23                                                 ^
 8:29.23 /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSUUID.h:29:30: error: nullability specifier '_Nonnull' cannot be applied to non-pointer type 'uuid_t' (aka 'unsigned char [16]')
 8:29.23 - (void)getUUIDBytes:(uuid_t _Nonnull)uuid;
 8:29.23                              ^
 8

Comment 1

[Matthew N. [:MattN]]

(In reply to Alexis Beingessner [:Gankro] from comment #0)
> (whether I'm using ICECC doesn't seem to affect it)

Are you sure you did a `mach clobber` after removing the icecc .mozconfig option?

I get past this error if I disable icecc in .mozconfig + clobber

I think the issue is that clang needs to be updated to a newer version in https://github.com/mstange/icecc-osx-moztor 

mstange, does that make sense? Do you have plans to do so?

Comment 2

[Aria Beingessner [:Gankra]]

I built with a fresh mozconfig, but I didn't give it a new target directory, so it might have cached some things. I'm currently just using an old sdk version, which works fine with icecc.

Comment 3

[Markus Stange [:mstange]]

(In reply to Matthew N. [:MattN] (huge backlog; PM if requests are blocking you) from comment #1)
> mstange, does that make sense? Do you have plans to do so?

Yes that makes sense. I'll take a look at updating to a more recent llvm tomorrow, with the hopes that this will actually fix the error.

In the meantime, the workaround is to get a pre-10.13 SDK from somewhere (e.g. from the machine of a colleague who hasn't updated their Xcode yet) and to add
ac_add_options --with-macos-sdk=/path/to/older/sdk
to one's mozconfig.

Comment 4

[Markus Stange [:mstange]]

I've updated the clang bundle at https://github.com/mstange/icecc-osx-moztor to a new version. This seems to build fine with the 10.13 SDK. The only problem at the moment is bug 1412240, so you currently have to apply the hackaround patch from that bug in order to get a working mozilla-central build.

So this is fixed. I'm closing it as invalid because it's not a bug in Firefox.