1401743 - [a11y] Pocket arrow is announced as "unlabelled button"

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Activity Stream, defect, P1)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

When swiping to navigate with Talkback, we announce (each line is a "next swipe"):
1) "Recommended by Pocket"
2) "more"
3) "Unlabelled button"

I'm concerned that 2) is lacking context with the visuals of being at the top of the Pocket items. 3) is not useful (perhaps we can put it in a ViewGroup with MORE and specify the whole container as the hit target?).

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Easy, let's fix it but we're breaking out announcing more to the next release because we can't uplift a string change.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1401743: Disable importance for accessibility of pocket MORE arrow.

The proper solution here is to put MORE and the arrow in a single focusable
container but this needs to get uplifted so I went with the simpler change.

For non-visual users, there is no difference. For visual users, the only "more"
is focused, rather than "more" and the arrow in one container. The code as it
is slightly more complex because we have to hide and add click listeners to
multiple objects.

Review commit: https://reviewboard.mozilla.org/r/182388/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182388/

Comment 3

[Chenxia Liu [:liuche]]

Comment on attachment 8910927 [details]
Bug 1401743: Disable importance for accessibility of pocket MORE arrow.

https://reviewboard.mozilla.org/r/182388/#review187732

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dbb8579cec0
Disable importance for accessibility of pocket MORE arrow. r=liuche

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8910927 [details]
Bug 1401743: Disable importance for accessibility of pocket MORE arrow.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1393174
[User impact if declined]: Talkback (a11y) users, can focus the arrow next to the MORE text and it will be announced as "Unlabelled button". This is especially awkward/mysterious/unpolished when swiping to navigation where you hear:
1) Recommended by Pocket (swipe)
2) More (swipe)
3) Unlabelled button

[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: Ideal. Comment 0 should suffice provided the QE is familiar with Talkback.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It's one line: we add an XML attribute that will not change the experience for non-accessibility users. iirc, if the attr was unavailable, it would be a compile error. If the value was unavailable, it'd be a runtime error we would have hit already.
[String changes made/needed]: None

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #5)
> [Needs manual test from QE? If yes, steps to reproduce]: Ideal. Comment 0
> should suffice provided the QE is familiar with Talkback.

That is, before we heard 1), 2), and 3) and after this patch, 3) - "Unlabelled button" - should no longer be heard.

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I was told I should NI sylvestre to make sure my change gets considered for 57 Beta.

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2dbb8579cec0

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8910927 [details]
Bug 1401743: Disable importance for accessibility of pocket MORE arrow.

Improve accessibility, taking it.
Should be in 57b3.

Comment 10

[Bogdan Surd, QA [:bsurd, NI]]

Checked this in Nightly 58 from 22-09-2017. The fix works, the arrow can no longer be selected for talkback users. Marking as verified for Nightly and will check again when this lands in beta 57, NI-ing myself in order to not forget about this.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7bab92eb9dc2