1401779 - Use new version of onCreateView

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The version we're currently using states [1]:

This implementation does nothing and is for pre-HONEYCOMB apps. Newer apps should use onCreateView(View, String, Context, AttributeSet).

---

We no longer support pre-HC devices so we should move to the new method.

[1]: https://developer.android.com/reference/android/app/Activity.html#onCreateView(java.lang.String,%20android.content.Context,%20android.util.AttributeSet)

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1401779: Use HC+ Actvitiy.onCreateView.

In the docs [1], the version of onCreateView we've been using states:

This implementation does nothing and is for pre-HONEYCOMB apps. Newer apps
should use onCreateView(View, String, Context, AttributeSet).

Since we no longer support pre-HC devices, this patch moves us to the new
version.

[1]: https://developer.android.com/reference/android/app/Activity.html#onCreateView(java.lang.String,%20android.content.Context,%20android.util.AttributeSet)

Review commit: https://reviewboard.mozilla.org/r/181966/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181966/

Comment 2

[Chenxia Liu [:liuche]]

Comment on attachment 8910531 [details]
Bug 1401779: Use HC+ Actvitiy.onCreateView.

https://reviewboard.mozilla.org/r/181966/#review187356

Since we're now r16+, I don't see any reason to not use the newer version of onCreateView. lgtm

::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:363
(Diff revision 1)
>      private final Set<String> mStreamIconLayoutFailedRequestCache = StreamOverridablePageIconLayout.newFailedRequestCache();
>  
>      private boolean mHasResumed;
>  
>      @Override
> -    public View onCreateView(final String name, final Context context, final AttributeSet attrs) {
> +    public View onCreateView(final View parent, final String name, final Context context, final AttributeSet attrs) {

Saw a note that parent might be null, but it looks like we don't use parent anyway.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22f5e644534b
Use HC+ Actvitiy.onCreateView. r=liuche

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/22f5e644534b