1401868 - Highlighted menulist's item doesn't align middle.

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Evan Tseng [:evanxd]]

Attachment: not-align-middle.png

Highlighted menulist's item doesn't align middle.

STR:
1. Search the "Arial" keyword.
2. Check the "Default font" setting.

Expected:
The highlighted "Arial" item should be aligned to middle.

Actual:
The highlighted "Arial" item doesn't align to middle. See it in the "not-align-middle.png" attachment.

And the issue happens on all platforms.

Comment 1

[Evan Tseng [:evanxd]]

Attachment: Bug 1401868 - Unset the line-height of the menulist label to make it align to the middle of the menulist.

Review commit: https://reviewboard.mozilla.org/r/182054/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182054/

Comment 2

[Evan Tseng [:evanxd]]

Comment on attachment 8910627 [details]
Bug 1401868 - Unset the line-height of the menulist label to make it align to the middle of the menulist.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/182054/diff/1-2/

Comment 3

[Evan Tseng [:evanxd]]

Hi Mike,

Could you help review this patch?

Thank you.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8910627 [details]
Bug 1401868 - Unset the line-height of the menulist label to make it align to the middle of the menulist.

https://reviewboard.mozilla.org/r/182054/#review189378

Looks okay to me. Perhaps do a browser-screenshots run to make sure the changes are fully expected?

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5447c1cbd95e
Unset the line-height of the menulist label to make it align to the middle of the menulist. r=mconley

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5447c1cbd95e

Comment 7

[Hani Yacoub, Desktop QA]

Build ID: 20170928100123
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

Verified as fixed on Firefox Nightly 58.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 16.04 x64.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Mike, is that something that we want in 57?

Comment 9

[Evan Tseng [:evanxd]]

Yes, I think so. I'm writing a comment and adding approval‑mozilla‑beta flag to uplift this to 57.

Comment 10

[Evan Tseng [:evanxd]]

Comment on attachment 8910627 [details]
Bug 1401868 - Unset the line-height of the menulist label to make it align to the middle of the menulist.

Approval Request Comment
[Feature/Bug causing the regression]: Not sure.

[User impact if declined]: A highlighted menulist's item doesn't align middle after search a keyword. Check the screenshot https://bug1401868.bmoattachments.org/attachment.cgi?id=8910621.
 
[Is this code covered by automated tests?]: No.

[Has the fix been verified in Nightly?]: Yes, already VERIFIED.

[Needs manual test from QE? If yes, steps to reproduce]: No.

[List of other uplifts needed for the feature/fix]: None.

[Is the change risky?]: No.

[Why is the change risky/not risky?]: We only adding a one line css style to fix this.

[String changes made/needed]: None.

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8910627 [details]
Bug 1401868 - Unset the line-height of the menulist label to make it align to the middle of the menulist.

Photon fit and finish, Beta57+

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b7170f074490

Comment 13

[Hani Yacoub, Desktop QA]

Build ID 	20171005195903
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Beta 57.0b6 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 16.04 x64.