Highlighted menulist's item doesn't align middle.

VERIFIED FIXED in Firefox 57

Status

()

defect
P3
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: evanxd, Assigned: evanxd)

Tracking

55 Branch
Firefox 57
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox57 verified, firefox58 verified)

Details

(Whiteboard: [photon-preference])

Attachments

(2 attachments)

Posted image not-align-middle.png
Highlighted menulist's item doesn't align middle.

STR:
1. Search the "Arial" keyword.
2. Check the "Default font" setting.

Expected:
The highlighted "Arial" item should be aligned to middle.

Actual:
The highlighted "Arial" item doesn't align to middle. See it in the "not-align-middle.png" attachment.

And the issue happens on all platforms.
Flags: qe-verify+
Whiteboard: [photon-preference][triage] → [photon-preference]
Attachment #8910627 - Flags: review?(mconley)
Hi Mike,

Could you help review this patch?

Thank you.
Priority: P1 → P3
Comment on attachment 8910627 [details]
Bug 1401868 - Unset the line-height of the menulist label to make it align to the middle of the menulist.

https://reviewboard.mozilla.org/r/182054/#review189378

Looks okay to me. Perhaps do a browser-screenshots run to make sure the changes are fully expected?

Thanks!
Attachment #8910627 - Flags: review?(mconley) → review+
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5447c1cbd95e
Unset the line-height of the menulist label to make it align to the middle of the menulist. r=mconley
https://hg.mozilla.org/mozilla-central/rev/5447c1cbd95e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Build ID: 20170928100123
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

Verified as fixed on Firefox Nightly 58.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 16.04 x64.
Mike, is that something that we want in 57?
Status: RESOLVED → VERIFIED
Flags: needinfo?(mconley)
Yes, I think so. I'm writing a comment and adding approval‑mozilla‑beta flag to uplift this to 57.
Flags: needinfo?(mconley)
Comment on attachment 8910627 [details]
Bug 1401868 - Unset the line-height of the menulist label to make it align to the middle of the menulist.

Approval Request Comment
[Feature/Bug causing the regression]: Not sure.

[User impact if declined]: A highlighted menulist's item doesn't align middle after search a keyword. Check the screenshot https://bug1401868.bmoattachments.org/attachment.cgi?id=8910621.
 
[Is this code covered by automated tests?]: No.

[Has the fix been verified in Nightly?]: Yes, already VERIFIED.

[Needs manual test from QE? If yes, steps to reproduce]: No.

[List of other uplifts needed for the feature/fix]: None.

[Is the change risky?]: No.

[Why is the change risky/not risky?]: We only adding a one line css style to fix this.

[String changes made/needed]: None.
Attachment #8910627 - Flags: approval-mozilla-beta?
Comment on attachment 8910627 [details]
Bug 1401868 - Unset the line-height of the menulist label to make it align to the middle of the menulist.

Photon fit and finish, Beta57+
Attachment #8910627 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Build ID 	20171005195903
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Beta 57.0b6 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 16.04 x64.
Flags: qe-verify+
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.