1401871 - Crash in java.lang.NullPointerException: Attempt to invoke interface method ''android.view.MenuItem android.view.MenuItem.setVisible(boolean)'' on a null object reference at org.mozilla.gecko.home.HomeFragment.onCreateContextMenu(HomeFragment.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

This bug was filed from the Socorro interface and is 
report bp-2459e70c-a005-45da-9587-3270f0170918.
=============================================================

Looks like a regression from bug 1329131

java.lang.NullPointerException: Attempt to invoke interface method 'android.view.MenuItem android.view.MenuItem.setVisible(boolean)' on a null object reference
	at org.mozilla.gecko.home.HomeFragment.onCreateContextMenu(HomeFragment.java:211)
	at android.view.View.createContextMenu(View.java:12533)
	at com.android.internal.view.menu.ContextMenuBuilder.showPopup(ContextMenuBuilder.java:100)
	at com.android.internal.policy.DecorView.showContextMenuForChildInternal(DecorView.java:822)
	at com.android.internal.policy.DecorView.showContextMenuForChild(DecorView.java:799)
	at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:879)
	at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:879)
	at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:879)
	at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:879)
	at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:879)
	at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:879)
	at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:879)
	at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:879)
	at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:879)
	at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:879)
	at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:879)
	at android.widget.AbsListView.performLongPress(AbsListView.java:3250)
	at android.widget.AbsListView$CheckForLongPress.run(AbsListView.java:3161)
	at android.os.Handler.handleCallback(Handler.java:789)
	at android.os.Handler.dispatchMessage(Handler.java:98)
	at android.os.Looper.loop(Looper.java:164)
	at android.app.ActivityThread.main(ActivityThread.java:6541)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

Comment 1

[Jing-wei Wu [:jwu]]

Attachment: Bug 1401871 - Check if menu item(home_add_to_launcher) exists or not before accessing it.

We temporarily hide `home_add_to_launcher` in API 26, which means directly accesses it without checking
if it exists or not would cause NullPointerException.

Review commit: https://reviewboard.mozilla.org/r/183510/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183510/

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8912134 [details]
Bug 1401871 - Check if menu item(home_add_to_launcher) exists or not before accessing it.

https://reviewboard.mozilla.org/r/183510/#review188800

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6282e18a63f6
Check if menu item(home_add_to_launcher) exists or not before accessing it. r=nechen

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6282e18a63f6

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Does this need a Beta approval request?

Comment 6

[Jing-wei Wu [:jwu]]

Yes, we should uplift this to beta, but I just found a better solution that would make the code logic more clear. I would create a follow-up bug and file a patch soon.

Comment 7

[Jing-wei Wu [:jwu]]

Hi Ryan,

Do we have to back out this patch to make the change in bug 1403437 can successfully be merged to beta without conflict?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

I don't see any reason why a patch from bug 1403437 would interfere with this one being uplifted to Beta. Sounds like it might be worth asking for uplift on that one too, though.

Comment 9

[Jing-wei Wu [:jwu]]

Comment on attachment 8912134 [details]
Bug 1401871 - Check if menu item(home_add_to_launcher) exists or not before accessing it.

Approval Request Comment
[Feature/Bug causing the regression]:
A crash on new version (Android O)

[User impact if declined]:
App crash on Android O after launching.

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Not yet

[Needs manual test from QE? If yes, steps to reproduce]: 
Yes, here is the STR:
1. Launch Fennec on Android O,
2. Tap 3-dot menu button on top-right,
3. Tap 'Page' option button,
4. Make sure there is no 'Add to Home Screen' option, and app doesn't crash

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
This patch only adds a null check to prevent NullPointerException.

[String changes made/needed]:
None

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8912134 [details]
Bug 1401871 - Check if menu item(home_add_to_launcher) exists or not before accessing it.

Fix a crash, taking it.
Should be in 57b4

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/06cffe71eae8

Comment 12

[Oana Horvath [:ohorvath - out of office]]

Verified as fixed on Beta 57.0b4.
Device: Nexus 6P (Android 8.0)