1401875 - Get rid of MALLOC_DECL_VOID

Status: RESOLVED FIXED

(Core :: Memory Allocator, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1401875 - Replace MALLOC_DECL_VOID with a clever use of templates.

This effectively means malloc_hook_table_t is now C++ only, which is not
a big problem.

This also makes some functions use a return construct with functions
that don't return a value (such as free). While that is not allowed in
ISO C, it's allowed in C++, so the simplification is welcome (although,
retrospectively, it turns out C compilers don't complain about it
without -pedantic).

Review commit: https://reviewboard.mozilla.org/r/182078/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182078/

Comment 2

[Mike Hommey [:glandium]]

FWIW, I verified it builds on all platforms with bug 1401101 backed out (which was the only thing actually actively using malloc_hook_table_t)

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 8910637 [details]
Bug 1401875 - Replace MALLOC_DECL_VOID with a clever use of templates.

https://reviewboard.mozilla.org/r/182078/#review187444

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f561b9294ae
Replace MALLOC_DECL_VOID with a clever use of templates. r=njn

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4f561b9294ae