1401982 - Trigger restart doorhanger if "Prevent accessibility services from accessing your browser" preference is toggled.

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

This preference checkbox sets accessibility.force_disable setting to 1. It is only taken into effect after restart. We need to trigger a restart doorhanger to not confuse users.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1401982 patch v1

Adding a prompt to restart.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8910799 [details] [diff] [review]
1401982 patch v1

Review of attachment 8910799 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for getting this in so quick!

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

[Tracking Requested - why for this release]: we should get this uplifted to 57 since the accessibility indicator is new for 57

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c68def04ec4
adding restart confirmation prompt when accessibility.force_disable is toggled. r=jaws

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6c68def04ec4

Comment 6

[Julien Cristau [:jcristau]]

Please request uplift to beta when you get a chance.

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8910799 [details] [diff] [review]
1401982 patch v1

This patch adds a restart prompt for a preference that requires restart. Without it the user will be confused as to why the pref is not doing anything until they restart on their own.
[Feature/Bug causing the regression]: Not a regression but a follow up to bug 1384567
[User impact if declined]: Users will not be aware that they need to restart after a preference change and will be confused why the feature is not on.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]:
* Open Privacy panel in preferences
* In permissions check/uncheck "Prevent accessibility services from accessing your browser" preference
* Expected: Restart or Revert dialog should be present.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: NA
[String changes made/needed]: None

Comment 8

[Sylvestre Ledru [:Sylvestre]]

> [Is the change risky?]: No
> [Why is the change risky/not risky?]: NA

Yura, could you please explicit why?
Thanks

Comment 9

[Yura Zenevich [:yzen] (please use "needinfo")]

This patch reuses an existing confirmRestartPrompt component and performs restart in the same way other preferences do it (such as e10s - https://dxr.mozilla.org/mozilla-central/source/browser/components/preferences/in-content/main.js#557-568). The only specific part of the code is reverting the check mark - https://github.com/mozilla/gecko-dev/blob/master/browser/components/preferences/in-content/privacy.js#L1657 which should be simple to verify with manual testing. Let me know if that's the right level of detail or if there are additional questions.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

This is perfect, thanks

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8910799 [details] [diff] [review]
1401982 patch v1

Fix an UX issue. taking it. Should be in 57b3

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b36a7a8a26a4

Comment 13

[Vlad Bacia-Mociran [:VladB]]

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20170929100122

This issue has been verified on latest Firefox Nightly Build ID: 20170929100122 on Windows 8.1 x64, Mac OS 10.12 and Ubuntu 14.04. When the checkbox for "Prevent accessibility services from accessing your browser" from "about:preferences#privacy -> Permissions" is checked, the Restart Nightly dialog is opened and has the [Restart] and [Revert] buttons. Clicking on Revert, the dialog is dismissed and the checkbox is unchecked. If the Restart option is clicked the browser is restarted and the option remains checked after the restart. Also, the value for accessibility.force_disabled pref from about:config will be changed to 1.

If the value for accessibility.force_disabled from about:config is manually changed from 0 to 1, the Restart Nightly dialog is not displayed. After a manual restart the "Prevent accessibility services from accessing your browser" option will be checked.

Comment 14

[Brindusa Tot, DTE]

Based on previous comment mark verified on Nightly 58.

Comment 15

[Alexandru Simonca [:asimonca], Release Desktop QA]

Verified fixed in Beta 57.b13 on Windows 10 x64, MacOS 10.13.1 and Ubuntu 14.04 x64.