1402007 - Permaoraonge on JSDCov toolkit/components/extensions/test/xpcshell/test_native_manifests.js | xpcshell return code: 0

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: ebalazs [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=132468551&repo=mozilla-central

https://queue.taskcluster.net/v1/task/V-Vmed-fR-e82csRolQ1Uw/runs/0/artifacts/public/logs/live_backing.log

Comment 2

[Tomislav Jovanovic :zombie]

This is an existing intermittent, the test file got renamed in bug 1386427.

Comment 3

[Intermittent Failures Robot]

16 failures in 943 pushes (0.017 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 16

Platform breakdown:
* linux64-jsdcov: 16

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1402007&startday=2017-09-18&endday=2017-09-24&tree=all

Comment 4

[Tomislav Jovanovic :zombie]

The problem is that this code:

http://searchfox.org/mozilla-central/source/toolkit/components/extensions/test/xpcshell/test_native_manifests.js#73

expects Subprocess.pathSearch() to return null, but it throws upon finding nothing.

An even better solution might be to read the $PYTHON environment variable directly.

Comment 5

[Intermittent Failures Robot]

48 failures in 885 pushes (0.054 failures/push) were associated with this bug in the last 7 days. 

This is the #38 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* mozilla-central: 48

Platform breakdown:
* linux64-jsdcov: 48

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1402007&startday=2017-09-25&endday=2017-10-01&tree=all

Comment 6

[Phil Ringnalda (:philor)]

Whatever else this is, it isn't intermittent.

Comment 7

[Greg Mierzwinski [:sparky]]

This bug may be related to the error found here based on comment 4: https://bugzilla.mozilla.org/show_bug.cgi?id=1400728

Both of these tests use Subprocess.pathSearch().

Comment 8

[Tomislav Jovanovic :zombie]

Attachment: Bug 1402007 - Use $PYTHON environment variable in test_native_manifest

Review commit: https://reviewboard.mozilla.org/r/186514/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186514/

Comment 9

[Bob Silverberg [:bsilverberg]]

Zombie is working on this one. Marking it as a P3 to remove it from triage.

Comment 10

[Andrew Swan [:aswan]]

Comment on attachment 8915319 [details]
Bug 1402007 - Use $PYTHON environment variable in test_native_manifest

https://reviewboard.mozilla.org/r/186514/#review192292

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd5bda402097
Use $PYTHON environment variable in test_native_manifest r=aswan

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bd5bda402097

Comment 13

[Intermittent Failures Robot]

22 failures in 824 pushes (0.027 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 22

Platform breakdown:
* linux64-jsdcov: 22

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1402007&startday=2017-10-02&endday=2017-10-08&tree=all

Comment 14

[Joel Maher ( :jmaher ) (UTC -8)]

thanks for the fix :zombie

Comment 15

[marius.santa]

Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.

Comment 16

[Tomislav Jovanovic :zombie]

This was a bug in our test code, no need for manual verification.