Closed
Bug 1402048
Opened 6 years ago
Closed 6 years ago
Remove the legacy non-IDNA2008 code path from nsIDNService, now that we always require ICU to build
Categories
(Core :: Networking, enhancement, P1)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
References
Details
Attachments
(1 file)
137.96 KB,
patch
|
valentin
:
review+
mcmanus
:
feedback+
|
Details | Diff | Splinter Review |
Now that we have ICU available in all our builds (i.e. ENABLE_INTL_API is used on all platforms), we no longer need to maintain this legacy code.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8910874 -
Flags: review?(mcmanus)
Updated•6 years ago
|
Priority: -- → P1
Updated•6 years ago
|
Attachment #8910874 -
Flags: review?(valentin.gosu)
Attachment #8910874 -
Flags: review?(mcmanus)
Attachment #8910874 -
Flags: feedback+
Comment 2•6 years ago
|
||
Comment on attachment 8910874 [details] [diff] [review] Remove the legacy non-IDNA2008 code path from nsIDNService, now that we always require ICU to build Review of attachment 8910874 [details] [diff] [review]: ----------------------------------------------------------------- Looks good!
Attachment #8910874 -
Flags: review?(valentin.gosu) → review+
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b9855e3e3ce3 Remove the legacy non-IDNA2008 code path from nsIDNService, now that we always require ICU to build. r=valentin
![]() |
||
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b9855e3e3ce3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•