Closed Bug 1402060 Opened 5 years ago Closed 5 years ago
Inset box shadows with spread also spread to the outside if an outset box shadow is present
In the testcase, there should be a gray shape with a dark blue border. There should be no light blue on this page.
https://github.com/servo/webrender/issues/1737 This affects the focus ring of the URL bar in the default Firefox theme on Mac.
5 years ago
Priority: -- → P3
5 years ago
Priority: P3 → P2
Whiteboard: [gfx-noted] → [wr-mvp] [gfx-noted]
This is not a WebRender bug, it's a bug in nsDisplayBoxShadowOuter::CreateWebRenderCommands, which creates outset box shadow items even for inset box shadows, because of a check that was forgotten in bug 1339661.
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8916293 [details] Bug 1402060 - Don't create outset box-shadow wr items for inset box-shadows. https://reviewboard.mozilla.org/r/187516/#review192564
Attachment #8916293 - Flags: review?(matt.woodrow) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/9f517e50e6ec Don't create outset box-shadow wr items for inset box-shadows. r=mattwoodrow
You need to log in before you can comment on or make changes to this bug.