Closed
Bug 1402060
Opened 8 years ago
Closed 8 years ago
Inset box shadows with spread also spread to the outside if an outset box shadow is present
Categories
(Core :: Graphics: WebRender, defect, P1)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
Details
(Whiteboard: [wr-mvp] [gfx-noted])
Attachments
(2 files)
In the testcase, there should be a gray shape with a dark blue border. There should be no light blue on this page.
|
Assignee | |
Comment 1•8 years ago
|
||
https://github.com/servo/webrender/issues/1737
This affects the focus ring of the URL bar in the default Firefox theme on Mac.
|
||
Updated•8 years ago
|
Priority: -- → P3
Whiteboard: [gfx-noted]
|
|
||
Updated•8 years ago
|
Blocks: stage-wr-trains
|
||
Updated•8 years ago
|
Priority: P3 → P2
Whiteboard: [gfx-noted] → [wr-mvp] [gfx-noted]
|
|
Assignee | |
Comment 2•8 years ago
|
||
This is not a WebRender bug, it's a bug in nsDisplayBoxShadowOuter::CreateWebRenderCommands, which creates outset box shadow items even for inset box shadows, because of a check that was forgotten in bug 1339661.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8916293 [details]
Bug 1402060 - Don't create outset box-shadow wr items for inset box-shadows.
https://reviewboard.mozilla.org/r/187516/#review192564
Attachment #8916293 -
Flags: review?(matt.woodrow) → review+
| Comment hidden (mozreview-request) |
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/9f517e50e6ec
Don't create outset box-shadow wr items for inset box-shadows. r=mattwoodrow
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•