Closed Bug 1402060 Opened 6 years ago Closed 6 years ago

Inset box shadows with spread also spread to the outside if an outset box shadow is present

Categories

(Core :: Graphics: WebRender, defect, P1)

Product:
Core
Component:
Graphics: WebRender
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

(Whiteboard: [wr-mvp] [gfx-noted])

Attachments

(2 files)

testcase
391 bytes, text/html
Details
Bug 1402060 - Don't create outset box-shadow wr items for inset box-shadows.
59 bytes, text/x-review-board-request
mattwoodrow
: review+
Details
Attached file testcase — 
In the testcase, there should be a gray shape with a dark blue border. There should be no light blue on this page.
https://github.com/servo/webrender/issues/1737

This affects the focus ring of the URL bar in the default Firefox theme on Mac.
Priority: -- → P3
Whiteboard: [gfx-noted]
Priority: P3 → P2
Whiteboard: [gfx-noted] → [wr-mvp] [gfx-noted]
This is not a WebRender bug, it's a bug in nsDisplayBoxShadowOuter::CreateWebRenderCommands, which creates outset box shadow items even  for inset box shadows, because of a check that was forgotten in bug 1339661.
Assignee: nobody → mstange
Blocks: 1339661
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8916293 [details]
Bug 1402060 - Don't create outset box-shadow wr items for inset box-shadows.

https://reviewboard.mozilla.org/r/187516/#review192564
Attachment #8916293 - Flags: review?(matt.woodrow) → review+
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/9f517e50e6ec
Don't create outset box-shadow wr items for inset box-shadows. r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/9f517e50e6ec
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.