Open Bug 1402104 Opened 2 years ago Updated 2 years ago

"mach vendor rust" fails to import crates even the same version is already in tree

Categories

(Firefox Build System :: General, defect)

57 Branch
defect
Not set

Tracking

(Not tracked)

People

(Reporter: whimboo, Unassigned)

References

Details

Trying to upgrade the third party rust crates while working on bug 1396821 caused the following strange output:

> $ mach vendor rust                                            1 ↵
>  0:01.53 rm -rf /Volumes/data/code/gecko/third_party/rust
>  0:12.07 The following files exceed the filesize limit of 102400:
> 
> third_party/rust/backtrace-sys-0.1.10/src/libbacktrace/configure
> third_party/rust/backtrace-sys-0.1.10/src/libbacktrace/ltmain.sh
> third_party/rust/clap-2.25.0/CHANGELOG.md
> third_party/rust/clap-2.25.0/src/args/arg.rs
> 
> Please find a way to reduce the sizes of these files or talk to a build
> peer about the particular large files you are adding.
> 
> The changes from `mach vendor rust` will NOT be added to version control.

Please note that backtrace-sys (https://hg.mozilla.org/mozilla-central/file/tip/third_party/rust/backtrace-sys) with the same version is already in tree but its folder name doesn't have the version included. clap is indeed a new release.
(In reply to Henrik Skupin (:whimboo) from comment #0)
> Please note that backtrace-sys
> (https://hg.mozilla.org/mozilla-central/file/tip/third_party/rust/backtrace-
> sys) with the same version is already in tree but its folder name doesn't
> have the version included. clap is indeed a new release.

Oh, I missed that point. That means that something else must be pulling in a different version of backtrace-sys, so this version looks like it's being newly-added because `third_party/rust/backtrace-sys` contains the newer version. It would be better to fix that if possible so we don't have to have two copies of this vendored.

The clap stuff might just be something we have to eat, although we could probably convince upstream to drop CHANGELOG.md from their crate, at least, since it's not providing any value there.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.