Closed
Bug 1402215
Opened 7 years ago
Closed 7 years ago
ServiceWorkerRegistrar should complete the shutting down procedure also when PBackground is not ready yet
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(1 obsolete file)
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8911047 -
Flags: review?(bugmail)
|
||
Comment 2•7 years ago
|
||
:bkelly, do you have any preferred approach between what I landed in https://bugzilla.mozilla.org/show_bug.cgi?id=1047098#c59 (expedited for 56) and this approach? Note that bug 1283609 landed, improving the "synchronously create PBackground" story. There was also some discussion on bug 1384618. No follow-up has been filed yet, but we might be much closer to PBackground always being synchronously created now. Feel free to steal the review, etc.
Flags: needinfo?(bkelly)
|
||
Comment 3•7 years ago
|
||
The current code looks better to me. I'm not sure it makes sense to create the PBackground actor in ProfileStopped if it doesn't already exist.
Flags: needinfo?(bkelly)
|
|
Assignee | |
Comment 4•7 years ago
|
||
(In reply to Ben Kelly [:bkelly] from comment #3)
> The current code looks better to me. I'm not sure it makes sense to create
> the PBackground actor in ProfileStopped if it doesn't already exist.
Yeah, I wrote this patch basically to support "fast" xpcshell tests.
|
|
||
Updated•7 years ago
|
Attachment #8911047 -
Attachment is obsolete: true
Attachment #8911047 -
Flags: review?(bugmail)
|
|
||
Comment 5•7 years ago
|
||
Resolving as fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1047098#c59
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•