1402221 - Add Telemetry probe to find out rtcp-mux usage

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, enhancement, P2)

Description

[Nils Ohlmeier [:drno]]

Before we implement and potentially switch our rtcp-mux policy from negotiate to require we should try to figure out how often rtcp-mux gets rejected.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1402221: add Telemetry probe to find out rtcp-mux usage.

Review commit: https://reviewboard.mozilla.org/r/182530/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182530/

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8911066 [details]
Bug 1402221: add Telemetry probe to find out rtcp-mux usage.

https://reviewboard.mozilla.org/r/182530/#review187926

Comment 3

[François Marier [:francois]]

Comment on attachment 8911066 [details]
Bug 1402221: add Telemetry probe to find out rtcp-mux usage.

https://reviewboard.mozilla.org/r/182530/#review187996

datareview+, with the additional email

::: toolkit/components/telemetry/Histograms.json:9226
(Diff revision 1)
>      "description": "Was DataChannels negotiated"
>    },
> +  "WEBRTC_RTCP_MUX": {
> +    "record_in_processes": ["main", "content"],
> +    "bug_numbers": [1402221],
> +    "alert_emails": ["[e-mail]"],

Can you please add your email address in there too. We now ask for a person to be listed next to each probe.

Comment 4

[Nils Ohlmeier [:drno]]

Comment on attachment 8911066 [details]
Bug 1402221: add Telemetry probe to find out rtcp-mux usage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/182530/diff/1-2/

Comment 5

[Nils Ohlmeier [:drno]]

Comment on attachment 8911066 [details]
Bug 1402221: add Telemetry probe to find out rtcp-mux usage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/182530/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/376f91c694a4
add Telemetry probe to find out rtcp-mux usage. r=bwc,francois

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/376f91c694a4