1402227 - Give focus to sidebar after keyboard shortcut (_execute_sidebar_action)

Status: RESOLVED DUPLICATE of bug 1324255

(WebExtensions :: Frontend, defect, P5)

Description

[Damien Cassou]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170921100141

Steps to reproduce:

- Create an add-on
- Add a sidebar_action to manifest and corresponding default_panel
- Add an _execute_sidebar_action command with a suggested_key

Open your add-on in Firefox and press the suggested_key.


Actual results:

The focus is still on the current tab's content (press Up/Down arrows to check it)


Expected results:

The focus is on the sidebar.

With current behavior, there is no way to control a sidebar extension with the keyboard only.

Comment 1

[Andy McKay]

Sorry, misunderstood the request. I think giving focus to the sidebar would be extension specific and I don't think we should do this, but moving over to the design-decision process.

Comment 2

[Damien Cassou]

The Bookmarks and the History sidebars have the focus automatically. Why can't add-on sidebars ask for focus as well?after

Comment 3

[Caitlin Neiman [:caitmuenster]]

Hi Damien, this has been added to the agenda for the February 20, 2018 WebExtensions APIs triage. Would you be able to join us? 

Here’s a quick overview of what to expect at the triage: 

* We normally spend 5 minutes per bug
* The more information in the bug, the better
* The goal of the triage is to give a general thumbs up or thumbs down on a proposal; we won't be going deep into implementation details

Relevant Links: 

* Wiki for the meeting: https://wiki.mozilla.org/WebExtensions/Triage#Next_Meeting
* Meeting agenda: https://docs.google.com/document/d/1-edU5RRFo2TupsOW400AcTOj8yyQnXd0F7uSsqkEzck/edit#
* Vision doc for WebExtensions: https://wiki.mozilla.org/WebExtensions/Vision

Comment 4

[Shane Caraveo (:mixedpuppy)]

Bug 1324255 (just landed in 60) should have provided this, will need to verify.

Comment 5

[Shane Caraveo (:mixedpuppy)]

I just tested this, focus is working fine with the command in fx60

Comment 6

[Damien Cassou]

I'm sorry but I'm on Nightly and when opening an extension's sidebar with a shortcut, pressing Up/Down arrow keys would move the webpage, not the sidebar's content. I've tried with the "Overview" web extension: 

- https://addons.mozilla.org/en-US/firefox/addon/overview/
- https://gitlab.petton.fr/DamienCassou/overview

Comment 7

[Tim Weißenfels]

This is not "RESOLVED". You still do not get focus in FF61 & 62.