1402234 - Remove ENABLE_INTL_API=no code from intl/locale

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Part of bug 1308359

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1402234 - Remove the ENABLE_INTL_API=no code from intl/locale.

Review commit: https://reviewboard.mozilla.org/r/182538/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182538/

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8911071 [details]
Bug 1402234 - Remove the ENABLE_INTL_API=no code from intl/locale.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/182538/diff/1-2/

Comment 3

[Jonathan Kew [:jfkthame]]

Rather than the mega-patch here, let's remove various parts of this in separate bugs for the individual functional units; then let's see what (if anything) remains. So holding off on this one for now....

Comment 4

[Jonathan Kew [:jfkthame]]

There are patches in separate bugs (see dependencies of bug 1387332) to handle most of this except for the intl/locale subdirectory. I would suggest morphing this bug to focus just on intl/locale/ and updating the patch accordingly; that'll be a nice clean unit of work to review&land.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8911071 [details]
Bug 1402234 - Remove the ENABLE_INTL_API=no code from intl/locale.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/182538/diff/2-3/

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Sounds good! Updated the patch to cover only intl/locale directory.

Comment 7

[Jonathan Kew [:jfkthame]]

Comment on attachment 8911071 [details]
Bug 1402234 - Remove the ENABLE_INTL_API=no code from intl/locale.

https://reviewboard.mozilla.org/r/182538/#review187886

LGTM, thanks!

Comment 8

[Jonathan Kew [:jfkthame]]

Well, assuming tryserver is now happy with it, that is. :)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b47963e73f8
Remove the ENABLE_INTL_API=no code from intl/locale. r=jfkthame

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7b47963e73f8