1402242 - Always use 2 bytes VP8 PictureId

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P2)

Comment 1

[Iñaki Baz Castillo]

Same as Chrome did recently:

https://bugs.chromium.org/p/webrtc/issues/detail?id=7877

By forcing the PictureId in VP8 payload to always be 2 bytes (regardless it's less than 0x80), SFUs servers don't need to perform a memmove on the payload when it comes to rewrite the PictureId field.

https://chromium.googlesource.com/external/webrtc.git/+/eb94436b386afb7165d91724893b6085365ca1ad%5E%21/#F0

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: use 2-byte vp8 picture ids always (cherrypick of issue 7877)

needed to modify the test changes slightly due to differences between upstream head and rev 57; you may want to run the upstream unittests by hand to check that it's right

Comment 3

[Dan Minor [:dminor]]

Comment on attachment 8911151 [details] [diff] [review]
use 2-byte vp8 picture ids always (cherrypick of issue 7877)

LGTM. I ran the tests locally and the changes are fine.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d8a4ea4b268
use 2-byte vp8 picture ids always (cherrypick of issue 7877) r=dminor

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0d8a4ea4b268

Comment 6

[Iñaki Baz Castillo]

Thanks :)