Closed
Bug 1402249
Opened 7 years ago
Closed 7 years ago
Add the first-session-shutdown document to the TOC
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: Dexter, Assigned: amiyaguchi)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.20 KB,
patch
|
Dexter
:
review+
|
Details | Diff | Splinter Review |
When building the docs locally, I get the following error: > checking consistency... > /home/.../telemetry/data/first-shutdown.rst: WARNING: document isn't included in any toctree We should add the reference to [1] and make sure the error goes away by checking the output of > ./mach doc [1] - https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/docs/data/index.rst
|
Reporter | |
Comment 1•7 years ago
|
||
Anthony, sorry for not catching this during the review: do you mind taking this up?
Points: --- → 1
Flags: needinfo?(amiyaguchi)
Priority: -- → P1
|
||
Updated•7 years ago
|
Assignee: nobody → amiyaguchi
Status: NEW → ASSIGNED
|
Assignee | |
Comment 2•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(amiyaguchi)
Attachment #8911274 -
Flags: review?(alessio.placitelli)
|
|
Reporter | |
Comment 3•7 years ago
|
||
Comment on attachment 8911274 [details] [diff] [review] Add the first-session-shutdown document to the TOC Review of attachment 8911274 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/telemetry/docs/data/index.rst @@ +15,4 @@ > backgroundhangmonitor-ping > anonymous-ping > *-ping > + first-shutdown Please move this above the *-ping entry.
Attachment #8911274 -
Flags: review?(alessio.placitelli)
|
|
Assignee | |
Comment 4•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8911274 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8912067 -
Flags: review?(alessio.placitelli)
|
|
Reporter | |
Comment 5•7 years ago
|
||
Comment on attachment 8912067 [details] [diff] [review] Add the first-session-shutdown document to the TOC Review of attachment 8912067 [details] [diff] [review]: ----------------------------------------------------------------- Thanks Anthony! Only one note: next time you rename a file, use "hg rename" because it will retain the file history. It's not a problem for this since there wasn't much action on this file :)
Attachment #8912067 -
Flags: review?(alessio.placitelli) → review+
|
|
Reporter | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/aef322779c5d Add the first-session-shutdown document to the TOC. r=Dexter
Keywords: checkin-needed
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/aef322779c5d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•