Open
Bug 1402250
Opened 7 years ago
Updated 26 days ago
Evaluate whether we still need -moz-crisp-edges on favicons
Categories
(Firefox :: Theme, enhancement, P3)
Firefox
Theme
Tracking
()
NEW
People
(Reporter: mak, Assigned: yazan)
References
(Blocks 2 open bugs)
Details
(Keywords: blocked-ux, Whiteboard: [sng][favicons-2024])
User Story
In a dependency bug, add new telemetry to measure how often the page-icon protocol serves icons smaller than requested (per each request increase a "small" or "fit" counter, so we can see in percentage how many requests will potentially show blurry icons). Then write a redash query to check it and take a decision. Note this doesn't necessarily apply to all favicon consumers, for example tabs don't use page-icon.
Attachments
(1 file)
|
59 bytes,
text/x-review-board-request
|
Details |
This is splitted from bug 1401851, even if we're now storing and using more hi dpi favicons, we are not yet comfortable with jut removing crisp-edges.
We need to collect and analyze more data to understand if we're at a point where crisp-edges does more damage than benefit.
We could store some telemetry about the percentage of pages in favicons.sqlite that don't have an icon larger than 16px. This together with the existing LINK_ICON_SIZES_ATTR_DIMENSIONS telemetry could help us making a call.
| Comment hidden (mozreview-request) |
|
Reporter | |
Comment 2•7 years ago
|
||
I posted the current patch, just as a placeholder, not intending to land it until we have data and a decision.
|
||
Updated•7 years ago
|
Priority: -- → P3
|
||
Comment 3•7 years ago
|
||
(In reply to Justin Dolske [:Dolske] from bug 1401777 comment #31)
> That this -moz-crisp-edges gets applied to favicons that are *downscaled* is unintentional.
At least for the in-tab favicon, similar to the fix in bug 1401777, it should be relatively straightforward to just pass the width data to set a style / class conditionally doing the crisp or smooth scaling.
|
|
Reporter | |
Comment 4•7 years ago
•
|
||
we don't always know the favicon size, since the "sizes" attribute is optional and often omitted.
|
||
Updated•2 years ago
|
Severity: normal → S3
|
|
||
Comment 5•3 months ago
|
||
Tagging this for the Search team to look into since we own bookmarks and history.
Keywords: blocked-ux
Whiteboard: [sng]
|
||
Updated•3 months ago
|
|
|
Reporter | |
Updated•3 months ago
|
Whiteboard: [sng] → [sng][favicons-2024]
|
|
Reporter | |
Updated•3 months ago
|
Points: --- → 2
User Story: (updated)
|
Assignee | |
Updated•2 months ago
|
Assignee: nobody → yalmacki
|
|
Assignee | |
Comment 6•26 days ago
|
||
Telemetry data shows that for users on Nightly 132 between 04-Sep-2024 and 10-Sep-2024, 4.2% of icons served by the page-icon protocol were smaller than requested.
You need to log in
before you can comment on or make changes to this bug.
Description
•