Closed
Bug 1402271
Opened 7 years ago
Closed 7 years ago
Remove support for non-ICU unicode character property tables.
Categories
(Core :: Internationalization, enhancement)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
References
Details
Attachments
(3 files)
23.55 KB,
patch
|
m_kato
:
review+
|
Details | Diff | Splinter Review |
667.96 KB,
patch
|
m_kato
:
review+
|
Details | Diff | Splinter Review |
12.10 KB,
patch
|
m_kato
:
review+
|
Details | Diff | Splinter Review |
We no longer need to maintain all the Unicode character property tables for category, script, bidi, etc., etc.; we only need to manage a couple of properties that ICU doesn't readily expose. So we can simplify the maintenance tool, and then regenerate the data files without the non-ICU sections.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8911099 -
Flags: review?(m_kato)
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8911102 -
Flags: review?(m_kato)
Assignee | ||
Comment 3•7 years ago
|
||
And with the legacy data tables gone, we no longer need the corresponding accessor code in nsUnicodeProperties, so we can drop all that.
Attachment #8911103 -
Flags: review?(m_kato)
Updated•7 years ago
|
Attachment #8911099 -
Flags: review?(m_kato) → review+
Updated•7 years ago
|
Attachment #8911102 -
Flags: review?(m_kato) → review+
Updated•7 years ago
|
Attachment #8911103 -
Flags: review?(m_kato) → review+
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f8dd96508eb3 patch 1 - Simplify the genUnicodePropertyData.pl tool to generate only the data we need to supplement ICU properties. r=m_kato https://hg.mozilla.org/integration/mozilla-inbound/rev/7d84de375402 patch 2 - Regenerate Unicode data tables with the stripped-down tool. r=m_kato https://hg.mozilla.org/integration/mozilla-inbound/rev/f637adb3bb88 patch 3 - Remove non-ENABLE_INTL_API code paths from the nsUnicodeProperties code. r=m_kato
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f8dd96508eb3 https://hg.mozilla.org/mozilla-central/rev/7d84de375402 https://hg.mozilla.org/mozilla-central/rev/f637adb3bb88
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•