Remove support for non-ICU unicode character property tables.

RESOLVED FIXED in Firefox 58

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

unspecified
mozilla58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

2 years ago
We no longer need to maintain all the Unicode character property tables for category, script, bidi, etc., etc.; we only need to manage a couple of properties that ICU doesn't readily expose. So we can simplify the maintenance tool, and then regenerate the data files without the non-ICU sections.
(Assignee)

Comment 3

2 years ago
And with the legacy data tables gone, we no longer need the corresponding accessor code in nsUnicodeProperties, so we can drop all that.
Attachment #8911103 - Flags: review?(m_kato)
(Assignee)

Updated

2 years ago
Blocks: 1387332
Attachment #8911099 - Flags: review?(m_kato) → review+
Attachment #8911102 - Flags: review?(m_kato) → review+
Attachment #8911103 - Flags: review?(m_kato) → review+

Comment 4

2 years ago
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8dd96508eb3
patch 1 - Simplify the genUnicodePropertyData.pl tool to generate only the data we need to supplement ICU properties. r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d84de375402
patch 2 - Regenerate Unicode data tables with the stripped-down tool. r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/f637adb3bb88
patch 3 - Remove non-ENABLE_INTL_API code paths from the nsUnicodeProperties code. r=m_kato

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f8dd96508eb3
https://hg.mozilla.org/mozilla-central/rev/7d84de375402
https://hg.mozilla.org/mozilla-central/rev/f637adb3bb88
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.