1402340 - Revert Windows sandbox in 57 to level 3

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Jim Mathies [:jimm]]

The alternate desktop restriction in content may have caused a few top crashes, we should pull this from 57 and re-target at 58 to give us some time to investigate and reduce risk in 57.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

I would like to get that in beta 3 (gtb next Monday)
Thanks!

Comment 2

[Bob Owen (:bobowen)]

Attachment: Revert back to Windows content process sandbox level 3 to fix suspected top crashes

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 8911193 [details] [diff] [review]
Revert back to Windows content process sandbox level 3 to fix suspected top crashes

Lets go ahead and confirm or deny the relationship here by landing this in beta 57.

Comment 4

[Bob Owen (:bobowen)]

Attachment: On non-Nightly revert back to Windows content process sandbox level 3 to fix suspected top crashes

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80f6fc604e5a
On non-Nightly revert back to Windows content process sandbox level 3 to fix suspected top crashes. r=jimm

Comment 6

[Bob Owen (:bobowen)]

Comment on attachment 8911201 [details] [diff] [review]
On non-Nightly revert back to Windows content process sandbox level 3 to fix suspected top crashes

Approval Request Comment
[Feature/Bug causing the regression]:
Potentially bug 1229829 or bug 1314801

[User impact if declined]:
The changes for Windows content process sandbox level 4 are suspected of causing top crashes on Nightly and Beta.
Bug 1356365 and bug 1400637.

[Is this code covered by automated tests?]:
This is just a pref flip to reduce the sandbox level on non-Nightly.

[Has the fix been verified in Nightly?]:
This will not affect Nightly.

[Needs manual test from QE? If yes, steps to reproduce]:
No, we need to see if this stops the crashes on Beta.

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
This is just a config change to drop the level in non-Nightly back to the same as Fx56, which is about to be released.

[String changes made/needed]:
None

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/80f6fc604e5a

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8911201 [details] [diff] [review]
On non-Nightly revert back to Windows content process sandbox level 3 to fix suspected top crashes

Taking in 57b3 to see if it decreases the volume of crashes

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8ee4c424d518