Closed
Bug 1402343
Opened 7 years ago
Closed 7 years ago
Update Codemirror to 5.30.0
Categories
(DevTools :: Source Editor, defect, P3)
DevTools
Source Editor
Tracking
(firefox57 fix-optional, firefox58 fixed)
RESOLVED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fix-optional |
| firefox58 | --- | fixed |
People
(Reporter: tjr, Assigned: gl)
References
(Blocks 1 open bug)
Details
(Whiteboard: [third-party-lib-audit])
Attachments
(1 file, 1 obsolete file)
|
102.13 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library. You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library. Codemirror is currently at version 5.29.0 in mozilla-central, and the latest version of the library released is 5.30.0. I fetched the latest version of the library from https://github.com/codemirror/CodeMirror/.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → gl
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f80572554b09f872da4d197dcb78b61740d1e5a1
Attachment #8911526 -
Flags: review?(bgrinstead)
|
|
Assignee | |
Comment 2•7 years ago
|
||
I couldn't find where the focus was breaking with this upgrade. So, I removed the focused element check in browser_dbg_search-basic-01.js since this was breaking only on the debugger.xul (with the blessing of jlast).
Attachment #8911526 -
Attachment is obsolete: true
Attachment #8911526 -
Flags: review?(bgrinstead)
Attachment #8911599 -
Flags: review?(bgrinstead)
|
|
Assignee | |
Comment 3•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=978c760f9672e98b6155e28b1425e6ae4d08a0be
|
||
Updated•7 years ago
|
status-firefox57:
--- → fix-optional
|
||
Updated•7 years ago
|
Attachment #8911599 -
Flags: review?(bgrinstead) → review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cb590aea27b5 Update Codemirror to 5.30.0. r=bgrins
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cb590aea27b5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•