1402370 - Fix GLBlitHelperD3D.cpp to compile under MinGW

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P3)

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1402370 nullptr cannot be cast to bool, so return false instead of nullptr in GLBlitHelperD3D.cpp

Review commit: https://reviewboard.mozilla.org/r/182718/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182718/

Comment 2

[Tom Ritter [:tjr]]

Attachment: Bug 1402370 _uuidof is a Microsoft specific extension while IID_* is a portable solution that will fix the MinGW build of GLBlitHelperD3D.cpp

Review commit: https://reviewboard.mozilla.org/r/182720/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182720/

Comment 3

[Tom Ritter [:tjr]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e89c18f2161e06ef82ac9e695372f47f606b0e18

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8911229 [details]
Bug 1402370 nullptr cannot be cast to bool, so return false instead of nullptr in GLBlitHelperD3D.cpp

https://reviewboard.mozilla.org/r/182718/#review188566

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8911230 [details]
Bug 1402370 _uuidof is a Microsoft specific extension while IID_* is a portable solution that will fix the MinGW build of GLBlitHelperD3D.cpp

https://reviewboard.mozilla.org/r/182720/#review188568

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abdad1de090e
nullptr cannot be cast to bool, so return false instead of nullptr in GLBlitHelperD3D.cpp r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/17a1159f7f4d
_uuidof is a Microsoft specific extension while IID_* is a portable solution that will fix the MinGW build of GLBlitHelperD3D.cpp r=jrmuizel

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/abdad1de090e
https://hg.mozilla.org/mozilla-central/rev/17a1159f7f4d