1402453 - Clicking twice the search icon with mouse makes the search bar deselected in about:newtab

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Mohammad Maruf Rahman]

Build ID   : 20170921100141
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:57.0) Gecko/20100101 
             Firefox/57.0
OS         : Windows 7, 64 Bit!

Steps to Reproduce : 
          
             1. Open Firefox Nightly and go to about:newtab
             2. Then select the search option 
             3. Beside the string 'search the web' you will see the search icon
             4. Click twice the search icon with mouse
             

Actual result      :

             The focused search bar flickers and the search bar gets deselected 

Expected result    : 
  
             The focused search bar should not flicker and the search bar should not get deselected.

Comment 1

[Mark Banner (:standard8)]

With activity stream disabled, clicking the search icon would de-focus the search bar (which may or may not be right overall), in any case, you don't get the flickering that you do with activity stream.

So I suspect this is an issue with activity stream and how they are managing focus for it (though we may need to fix the focussing in the search.xml) - moving to the new tab component for more diagnosis.

Comment 2

[Ed Lee :Mardak]

Ah it's probably because the icon is a <label> which moves focus from it to the input box.

Comment 3

[Ed Lee :Mardak]

The flickering was fixed by https://github.com/mozilla/activity-stream/pull/3588 to be uplifted via bug 1403215.

The deselecting I believe is just how labels work as Standard8 pointed out in comment 1 disabled. If it were text, the text would end up being selected instead of the input:

data:text/html,<label for="i">Label</label><input id="i"/>

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Bug 1403215 hasn't actually made it to m-c yet.

Comment 5

[Ethan Tseng [:ethan]]

Hi Ed, could you request an uplift to beta 57?

Comment 6

[Ed Lee :Mardak]

Does this need to be uplifted?

Comment 7

[Ethan Tseng [:ethan]]

(In reply to Ed Lee :Mardak from comment #6)
> Does this need to be uplifted?

Oops, I didn't notice there's no patch for this bug.
According to comment 3, this will be handled in bug 1403215.
So ignore my question.  Thanks, Ed.

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/79375774e4fe

Comment 9

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 57.0a1 (2017-09-22) in Ubuntu 16.04 LTS!

This bug's fix is verified with latest Beta and latest Nightly!

Build ID   : 20171005195903
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0

Build ID   : 20171008131700
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0

Comment 10

[Sajedul Islam]

I have reproduced this bug with Nightly 57.0a1 (2017-09-21) on Windows 10 , 64 Bit ! 
 
This bug's fix is Verified with latest Beta and latest Nightly !

Build   ID    20171005195903
User Agent    Mozilla/5.0 (Windows NT 10.0; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0

Build   ID    20171008131700
User Agent    Mozilla/5.0 (Windows NT 10.0; WOW64; rv:58.0) Gecko/20100101 Firefox/58.0

[bugday-20171004]

Comment 11

[Mohammad Maruf Rahman]

As per comment 9 and comment 10, I am marking this bug as Verified Fixed!