Open Bug 1402533 Opened 2 years ago Updated 2 years ago

Look for commits that change .pb.h or .pb.cc files without also changing a .proto file

Categories

(Testing :: General, enhancement, P3)

Version 3
enhancement

Tracking

(Not tracked)

People

(Reporter: francois, Unassigned)

References

Details

Files that end in .pb.h and .pb.cc are generated from a protobuf definition file (.proto) and start with this warning:

// Generated by the protocol buffer compiler.  DO NOT EDIT!
// source: LayerScopePacket.proto

However, it can slip through reviews and lead to commits where the .proto is out of sync with the generated files and cannot re-generate the files as they are in the codebase.

Here are two examples of commits which forgot to update the .proto:

https://hg.mozilla.org/mozilla-central/rev/f2d4190eaaf8
https://hg.mozilla.org/mozilla-central/rev/48b29a84e4e5

It would be great if we could detect that automatically and fail the build on Try.
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.