Closed Bug 1402549 Opened 3 years ago Closed 2 years ago

Intermittent testSessionFilePreservation | Exception caught - java.lang.ArrayIndexOutOfBoundsException: length=3; index=3

Categories

(Firefox for Android :: Session Restore, defect, P3)

All
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox60 --- fixed
firefox61 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: JanH)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

https://wiki.mozilla.org/Bugmasters#Intermittent_Test_Failure_Cleanup
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Not a Layout test. Re-routing...
Blocks: 1389564
Component: Layout → Testing
Flags: needinfo?(bugs) → needinfo?(jh+bugzilla)
Product: Core → Firefox for Android
Target Milestone: --- → Firefox 57
Version: unspecified → Trunk
We seem to have a tab more than expected, so I'd guessing we're hitting a session store file that was written just between these two statements:
https://dxr.mozilla.org/mozilla-central/rev/5454ed95c82a956009db2f4b04d008ec8753e61e/mobile/android/tests/browser/robocop/src/org/mozilla/gecko/tests/testSessionFilePreservation.java#48-49

So two things to do here:
1. Let the session JSON verification function compare the actual and expected tab count as well, so we don't crash and instead wait up to SESSION_TIMEOUT until the correct session store file has eventually been written after that temporary tab is closed again
2. Find a better way of triggering a session store write, possibly by introducing a dedicated EventDispatcher message that we can use during testing.
Assignee: nobody → jh+bugzilla
Component: Testing → Session Restore
Flags: needinfo?(jh+bugzilla)
OS: Unspecified → Android
Priority: P5 → P3
Hardware: Unspecified → All
See Also: → 1438997
Comment on attachment 8957820 [details]
Bug 1402549 - Part 1 - Assert number of saved tabs, too.

https://reviewboard.mozilla.org/r/226804/#review233238
Attachment #8957820 - Flags: review?(esawin) → review+
Comment on attachment 8957821 [details]
Bug 1402549 - Part 2 - Use something else to trigger session store activity.

https://reviewboard.mozilla.org/r/226806/#review233240
Attachment #8957821 - Flags: review?(esawin) → review+
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/5de3ada56349
Part 1 - Assert number of saved tabs, too. r=esawin
https://hg.mozilla.org/integration/autoland/rev/c6ad03aa476f
Part 2 - Use something else to trigger session store activity. r=esawin
https://hg.mozilla.org/mozilla-central/rev/5de3ada56349
https://hg.mozilla.org/mozilla-central/rev/c6ad03aa476f
Status: REOPENED → RESOLVED
Closed: 3 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 57 → Firefox 61
You need to log in before you can comment on or make changes to this bug.