1402592 - Crash in shutdownhang | ZwWaitForKeyedEvent | RtlSleepConditionVariableCS | SleepConditionVariableCS | mozilla::detail::ConditionVariableImpl::wait | mozilla::CondVar::Wait | mozilla::ThreadEventQueue<T>::GetEvent

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect, P1)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is 
report bp-294ba17c-b23d-462a-8dc2-23f7f0170923.
=============================================================

There are 29 crashes on nightly 57-58 starting with buildid 20170921100141. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1389021.

[1] https://hg.mozilla.org/mozilla-central/rev/4dd86bbce649

Comment 1

[[:philipp]]

hi, i think it's mainly a shift/change in signature generation due to bug 1402037

Comment 2

[[:philipp]]

oh sorry, please disregard the prior comment - the reports started coming in even before the change in signature generation yesterday.

Comment 3

[Calixte Denizet (:calixte)]

[Tracking Requested - why for this release]:
There are 97 crashes for 66 installations in 57.0b (dev edition).

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Ensure that ImageBridgeParent instances are closed by the parent during shutdown., v1

This should do it, I think.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=80e7c2b2cfe5fed577027503a700db3265c425db

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/99dcb764fd9f
Ensure that ImageBridgeParent instances are closed by the parent during shutdown. r=dvander

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/99dcb764fd9f

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 8912241 [details] [diff] [review]
Ensure that ImageBridgeParent instances are closed by the parent during shutdown., v1

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1401668
[User impact if declined]: May experience shutdown hangs on Windows.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: Yes, crash reports stopped on nightly after landing the patch.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No.
[Why is the change risky/not risky?]: We landed a similar fix for a different protocol on 56.0. The content process could already handle the parent shutting it down because the GPU process can die at any moment.
[String changes made/needed]: N/A

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8912241 [details] [diff] [review]
Ensure that ImageBridgeParent instances are closed by the parent during shutdown., v1

Fix a top crash, taking it.
Should be in 57b4

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/94e44c1f0875

Comment 11

[Andrei Vaida [:avaida]]

(In reply to Andrew Osmond [:aosmond] from comment #7)
> [Is this code covered by automated tests?]: Yes.
> [Has the fix been verified in Nightly?]: Yes, crash reports stopped on
> nightly after landing the patch.
> [Needs manual test from QE? If yes, steps to reproduce]: No.

Setting qe-verify- based on Andrew's assessment on manual testing needs and the fact that this fix has automated coverage.