1402622 - Firefox Quantum gets cut off on the About dialog

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P5)

Description

[Ryan VanderMeulen [:RyanVM]]

Attachment: Firefox Quantun

I run local builds with official branding and noticed today that Quantum gets cut off. I assume we want to fix this :)

Comment 1

[Ryan VanderMeulen [:RyanVM]]

I'm on a hi-dpi system too in case that's important.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Linux screenshot

Can't reproduce on Linux...

Comment 3

[Stephen Horlander [:shorlander]]

Also works on macOS. Will see if I can reproduce on Windows.

Comment 4

[Stephen Horlander [:shorlander]]

Attachment: Beta 57 - Windows 10

Here is what I get on today's beta on Windows 10.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

I see the same on 57 Beta builds. As I mentioned on IRC yesterday, I suspect this is a quirk of building trunk with official branding. I noticed when comparing the dialogs side by side that the Beta one is a bit wider and not quite as tall. Anyway, certainly not nearly as important now since this is extreme edge case :)

Comment 6

[Adam Roach [:abr]]

I'm seeing this on two different installs -- one on a machine with HiDpi, and one on a machine without. Both are Macs. This are official builds, downloaded via the Beta distribution channel. Let me know if there's anything I can do to help isolate the issue.

Comment 7

[Adam Roach [:abr]]

Attachment: MacOS, official Beta build, non-HiDPI

Comment 8

[Adam Roach [:abr]]

Attachment: MacOS, official Beta build, HiDPI

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Adam said on IRC he was using OSX 10.10. I haven't been able to reproduce on Retina MBP w/ 10.12 on it nor on two other Win10 laptops in my possession, but it appears we're not entirely out of the woods here yet either. Stephen, any thoughts on how to proceed?

Comment 10

[Stephen Horlander [:shorlander]]

I can't reproduce this anywhere. I am not sure what is causing it.

Changing the dimensions of the wordmark.svg might fix it.

Comment 11

[Stephen Horlander [:shorlander]]

Attachment: update-quantum-wordmark.patch

This makes the wordmark a little smaller. Should hopefully prevent it from getting cropped.

Comment 12

[Dão Gottwald [:dao]]

Comment on attachment 8912410 [details] [diff] [review]
update-quantum-wordmark.patch

>+<svg data-name="Layer 1" xmlns="http://www.w3.org/2000/svg" width="300" height="38" viewBox="0 0 300 38">
>+  <g fill="#fff">

nits:
- remove data-name="Layer 1"
- set fill on the svg node and remove <g>

Comment 13

[Stephen Horlander [:shorlander]]

Attachment: update-quantum-wordmark.patch

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ab11fa73cc4
Reduce size of Quantum wordmark to prevent it from possibly getting cropped. r=dao

Comment 15

[Dão Gottwald [:dao]]

Comment on attachment 8912665 [details] [diff] [review]
update-quantum-wordmark.patch

Approval Request Comment
[Feature/Bug causing the regression]: bug 1398319
[User impact if declined]: about dialog wordmark might be cropped, exact conditions are unclear
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: no, Ryan or Adam should just verify this
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: only makes the svg a bit smaller
[String changes made/needed]: /

Comment 17

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8912665 [details] [diff] [review]
update-quantum-wordmark.patch

Seems like a good idea to fix this promptly, Beta57+

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c4367bba6dbd

Comment 19

[Adam Roach [:abr]]

Attachment: About dialog with new svg

This appears to have fixed the problem on the systems I have access to.

Verified with `mozregression --repo mozilla-beta --launch c4367bba6dbd`

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9ab11fa73cc4

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Looking good here now too. Thanks!

Comment 22

[Andrei Vaida [:avaida]]

Since this is a very user-facing area, I think it's best to be safe and double-check this on Beta 57.